diff options
| author | Justin Stephenson <jstephen@redhat.com> | 2017-04-26 15:45:33 -0400 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2017-05-09 13:27:55 +0200 |
| commit | e98d085b529e0ae5e07a717ce3b30f3943be0ee0 (patch) | |
| tree | 79942b8cfe9b0cad601f3d9e5d2e9316c5669e6b | |
| parent | 133ee2239498b4c4fd95e509b72f2e9ef2620584 (diff) | |
| download | sssd-e98d085b529e0ae5e07a717ce3b30f3943be0ee0.tar.gz sssd-e98d085b529e0ae5e07a717ce3b30f3943be0ee0.tar.xz sssd-e98d085b529e0ae5e07a717ce3b30f3943be0ee0.zip | |
DP: Reduce Data Provider log level noise
Certain operations are not supported with certain providers
causing informational Data Provider log messages to be logged as
errors or failures. This patch lowers the log level to reduce overall
log noise and ensure only critical log messages are logged when
a low debug_level value is used.
Resolves:
https://pagure.io/SSSD/sssd/issue/3287
https://pagure.io/SSSD/sssd/issue/3278
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
| -rw-r--r-- | src/providers/data_provider/dp_methods.c | 2 | ||||
| -rw-r--r-- | src/providers/data_provider/dp_targets.c | 2 | ||||
| -rw-r--r-- | src/responder/common/responder_dp.c | 13 |
3 files changed, 13 insertions, 4 deletions
diff --git a/src/providers/data_provider/dp_methods.c b/src/providers/data_provider/dp_methods.c index 498676d1b..9e49c5f5d 100644 --- a/src/providers/data_provider/dp_methods.c +++ b/src/providers/data_provider/dp_methods.c @@ -109,7 +109,7 @@ errno_t dp_find_method(struct data_provider *provider, } if (!dp_target_initialized(provider->targets, target)) { - DEBUG(SSSDBG_CRIT_FAILURE, "Target [%s] is not initialized\n", + DEBUG(SSSDBG_CONF_SETTINGS, "Target [%s] is not initialized\n", dp_target_to_string(target)); return ERR_MISSING_DP_TARGET; } diff --git a/src/providers/data_provider/dp_targets.c b/src/providers/data_provider/dp_targets.c index 26d20a8ef..e2a45bbac 100644 --- a/src/providers/data_provider/dp_targets.c +++ b/src/providers/data_provider/dp_targets.c @@ -284,7 +284,7 @@ static errno_t dp_target_init(struct be_ctx *be_ctx, if (!target->explicitly_configured && (ret == ELIBBAD || ret == ENOTSUP)) { /* Target not found but it wasn't explicitly * configured so we shall just continue. */ - DEBUG(SSSDBG_CRIT_FAILURE, "Target [%s] is not supported by " + DEBUG(SSSDBG_CONF_SETTINGS, "Target [%s] is not supported by " "module [%s].\n", target->name, target->module_name); ret = EOK; goto done; diff --git a/src/responder/common/responder_dp.c b/src/responder/common/responder_dp.c index 080f70fd5..a75a61196 100644 --- a/src/responder/common/responder_dp.c +++ b/src/responder/common/responder_dp.c @@ -218,8 +218,17 @@ static int sss_dp_get_reply(DBusPendingCall *pending, err = ETIME; goto done; } - DEBUG(SSSDBG_FATAL_FAILURE,"The Data Provider returned an error [%s]\n", - dbus_message_get_error_name(reply)); + + if (strcmp(dbus_message_get_error_name(reply), + SBUS_ERROR_DP_NOTSUP) == 0) { + DEBUG(SSSDBG_CONF_SETTINGS, + "Data Provider does not support this operation.\n"); + } else { + DEBUG(SSSDBG_FATAL_FAILURE, + "The Data Provider returned an error [%s]\n", + dbus_message_get_error_name(reply)); + } + /* Falling through to default intentionally*/ SSS_ATTRIBUTE_FALLTHROUGH; default: |