diff options
author | Sumit Bose <sbose@redhat.com> | 2016-02-10 15:15:41 +0100 |
---|---|---|
committer | Lukas Slebodnik <lslebodn@redhat.com> | 2016-02-11 14:39:12 +0100 |
commit | a0c764a36f2f432e6063de84be6f6af7e96ec159 (patch) | |
tree | 943cdaa2ed48cf66a54f9439702502145a7fce17 | |
parent | d862e55716e1b24168fd5deef44c4f9deb7c0709 (diff) | |
download | sssd-a0c764a36f2f432e6063de84be6f6af7e96ec159.tar.gz sssd-a0c764a36f2f432e6063de84be6f6af7e96ec159.tar.xz sssd-a0c764a36f2f432e6063de84be6f6af7e96ec159.zip |
Just return NULL if tevent_req_create() fails
In general we just return NULL if tevent_req_create() fails because
there is nothing we can do with the request anyway. Especially
tevent_req_error() should not be called because it tries to dereference
req.
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
-rw-r--r-- | src/providers/ldap/ldap_id.c | 3 | ||||
-rw-r--r-- | src/resolv/async_resolv.c | 3 | ||||
-rw-r--r-- | src/responder/autofs/autofssrv_dp.c | 3 | ||||
-rw-r--r-- | src/responder/ssh/sshsrv_dp.c | 3 | ||||
-rw-r--r-- | src/responder/sudo/sudosrv_dp.c | 3 |
5 files changed, 5 insertions, 10 deletions
diff --git a/src/providers/ldap/ldap_id.c b/src/providers/ldap/ldap_id.c index a51c5271b..b7cef4e13 100644 --- a/src/providers/ldap/ldap_id.c +++ b/src/providers/ldap/ldap_id.c @@ -1490,8 +1490,7 @@ sdap_handle_acct_req_send(TALLOC_CTX *mem_ctx, req = tevent_req_create(mem_ctx, &state, struct sdap_handle_acct_req_state); if (!req) { - ret = ENOMEM; - goto done; + return NULL; } state->ar = ar; diff --git a/src/resolv/async_resolv.c b/src/resolv/async_resolv.c index 103592420..58d5c6e55 100644 --- a/src/resolv/async_resolv.c +++ b/src/resolv/async_resolv.c @@ -694,8 +694,7 @@ resolv_gethostbyname_files_send(TALLOC_CTX *mem_ctx, req = tevent_req_create(mem_ctx, &state, struct gethostbyname_files_state); if (req == NULL) { - tevent_req_error(req, ENOMEM); - goto done; + return NULL; } state->resolv_ctx = ctx; diff --git a/src/responder/autofs/autofssrv_dp.c b/src/responder/autofs/autofssrv_dp.c index 041f0629e..5793e40fc 100644 --- a/src/responder/autofs/autofssrv_dp.c +++ b/src/responder/autofs/autofssrv_dp.c @@ -56,8 +56,7 @@ sss_dp_get_autofs_send(TALLOC_CTX *mem_ctx, req = tevent_req_create(mem_ctx, &state, struct sss_dp_req_state); if (!req) { - ret = ENOMEM; - goto error; + return NULL; } if (!dom) { diff --git a/src/responder/ssh/sshsrv_dp.c b/src/responder/ssh/sshsrv_dp.c index 90b0b5754..b9878f8bc 100644 --- a/src/responder/ssh/sshsrv_dp.c +++ b/src/responder/ssh/sshsrv_dp.c @@ -56,8 +56,7 @@ sss_dp_get_ssh_host_send(TALLOC_CTX *mem_ctx, req = tevent_req_create(mem_ctx, &state, struct sss_dp_req_state); if (!req) { - ret = ENOMEM; - goto error; + return NULL; } if (!dom) { diff --git a/src/responder/sudo/sudosrv_dp.c b/src/responder/sudo/sudosrv_dp.c index 95595fba2..3c3ac8b75 100644 --- a/src/responder/sudo/sudosrv_dp.c +++ b/src/responder/sudo/sudosrv_dp.c @@ -62,8 +62,7 @@ sss_dp_get_sudoers_send(TALLOC_CTX *mem_ctx, req = tevent_req_create(mem_ctx, &state, struct sss_dp_req_state); if (!req) { - ret = ENOMEM; - goto error; + return NULL; } if (!dom) { |