summaryrefslogtreecommitdiffstats
path: root/src/software
diff options
context:
space:
mode:
authorMichal Minar <miminar@redhat.com>2013-09-12 12:14:33 +0200
committerMichal Minar <miminar@redhat.com>2013-09-12 15:04:07 +0200
commitab89ca56c4557ce87e76aa41ee54bed333d9ca41 (patch)
tree435e908543745acc3d51e5ef9865d19241750e94 /src/software
parentcfa3ea986239abdc4f4923bd7a415f6c342c0d66 (diff)
downloadopenlmi-providers-ab89ca56c4557ce87e76aa41ee54bed333d9ca41.tar.gz
openlmi-providers-ab89ca56c4557ce87e76aa41ee54bed333d9ca41.tar.xz
openlmi-providers-ab89ca56c4557ce87e76aa41ee54bed333d9ca41.zip
logging improvements and fix
Reduced length of tracing messages written to log by rendering just the first item of list, dict or set instead of whole argument. This will also improve execution time when running in debug mode. Fixed logging decorator of software job manager which previously rendered informations from uninteresting frame.
Diffstat (limited to 'src/software')
-rw-r--r--src/software/lmi/software/yumdb/jobmanager.py8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/software/lmi/software/yumdb/jobmanager.py b/src/software/lmi/software/yumdb/jobmanager.py
index 6b0b854..1b986bd 100644
--- a/src/software/lmi/software/yumdb/jobmanager.py
+++ b/src/software/lmi/software/yumdb/jobmanager.py
@@ -69,7 +69,7 @@ def job_handler(job_from_target=True):
it an instance of YumJob. The method is then called with "job" argument
instead of "target".
"""
- logged = cmpi_logging.trace_method(method)
+ logged = cmpi_logging.trace_method(method, frame_level=2)
def _new_func(self, *args, **kwargs):
"""Wrapper around method."""
@@ -294,7 +294,8 @@ class JobManager(threading.Thread):
LOG.exception("control job %s failed", job)
job.finish(result, data)
LOG.debug("sending reply for %s: (%s, %s)", job,
- job.ResultNames[job.result], job.result_data)
+ job.ResultNames[job.result],
+ cmpi_logging.render_value(job.result_data))
self._queue_out.put(job)
else:
if job is None:
@@ -508,7 +509,8 @@ class JobManager(threading.Thread):
ind.send(True)
else:
LOG.debug("sending reply for %s: (%s, %s)", job,
- job.ResultNames[job.result], job.result_data)
+ job.ResultNames[job.result],
+ cmpi_logging.render_value(job.result_data))
self._queue_out.put(job)
return job