diff options
| author | Tomas Bzatek <tbzatek@redhat.com> | 2013-10-14 14:14:51 +0200 |
|---|---|---|
| committer | Tomas Bzatek <tbzatek@redhat.com> | 2013-10-14 14:14:51 +0200 |
| commit | 7584e2fb80a74b7e4db3b653937a2c6ee64a7400 (patch) | |
| tree | d4163d5daaac696fe0553ee439f8b652b9326f52 /src/realmd | |
| parent | 0a30753fc90ae40f95add1eeb6eb2f36dd08a58f (diff) | |
| download | openlmi-providers-7584e2fb80a74b7e4db3b653937a2c6ee64a7400.tar.gz openlmi-providers-7584e2fb80a74b7e4db3b653937a2c6ee64a7400.tar.xz openlmi-providers-7584e2fb80a74b7e4db3b653937a2c6ee64a7400.zip | |
realmd: Fix unchecked result
Found by Coverity Scan. The change is really not needed, the iter variable
is initialized NULL and subsequent g_variant_iter_next() call should return
immediately, preventing the cycle to run.
But, just to be on a safe side...
Diffstat (limited to 'src/realmd')
| -rw-r--r-- | src/realmd/LMI_RealmdServiceProvider.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/realmd/LMI_RealmdServiceProvider.c b/src/realmd/LMI_RealmdServiceProvider.c index bd713b8..8ecd381 100644 --- a/src/realmd/LMI_RealmdServiceProvider.c +++ b/src/realmd/LMI_RealmdServiceProvider.c @@ -30,7 +30,9 @@ get_joined_domain(GVariant *provider_props) CMSetStatus(&status, CMPI_RC_OK); - g_variant_lookup(provider_props, "Realms", "ao", &iter); + if (!g_variant_lookup(provider_props, "Realms", "ao", &iter)) + goto exit; + while (g_variant_iter_next(iter, "&o", &realm_obj_path)) { GET_DBUS_PROPERIES_OR_EXIT(realm_props, realm_obj_path, REALM_DBUS_REALM_INTERFACE, &status); |