| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
| |
Signed-off-by: Martin Sivak <msivak@redhat.com>
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makefile:
1. Cut counts from 1 not 0.
2. Create the "about" info in the makefile instead of spec file.
3. Put subdirs and about targets into one build target.
firstaidkit.spec:
1. Erase the about creation from here.
2. Erase the fedora 7 specific stuff.
3. Call make build.
4. xserver plugin does not need rhpl nor rhpxl anymore.
5. Actually include the COPYING file where the about says it is.
configuration.py:
1. Change the default backup dir from /tmp/fakbackup to /tmp.
/tmp/fakbackup caused some file permission strangeness when
a non root user executed fak after root had executed it. This
can still occur, but it will be left like this as the user
should not execute fak in non root anyway.
logging:
plugins.py,interpreter.py. __init__.py
1. Always use the reporting object when possible.
2. Add time stamp and level of message to log messages.
|
| |
|
|
|
|
|
|
|
|
| |
- The "_p" is not needed. Avoiding the suffix makes the names simpler.
- When the plugin needs to be separated into varios subplugins,
use the _ to signify that a subplugin is related to a father
plugin. Like rpm_lowlevel, this say that lowlevel is part of
the rpm plugin.
- When naming a plugin keep the name SHORT and simple.
- Be sure to name all the plugin packages as "plugin-name"
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
- Indendtation should be 4 spaces. There was a function indented with
8 spaces.
- Lines should be shorted than 80 chars. It just looks pretty :)
Think of terminals whith only 80 char of length. Think of debuging
in rescue mode.
- Change also the print statements. Just getting ready for python 3000.
- Get some spaces between elifs
- There should not be any lines ending in spaces.
- This can all be read in the python code conventions
http://www.python.org/dev/peps/pep-0008/
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit c3bc3747deca5e558f26c0e49fba7aa0525daaf7
Author: Joel Andres Granados <jgranado@redhat.com>
Date: Fri Mar 7 13:12:18 2008 +0100
Just install the py files.
commit 111d1ae995cbb45eb384292baf81ebcf8ae2f9b4
Author: Joel Andres Granados <jgranado@redhat.com>
Date: Fri Mar 7 11:53:45 2008 +0100
Clean the spec file
commit 21f00dbefaa2cf80a8a028c13931891ecd4294c2
Author: Joel Andres Granados <jgranado@redhat.com>
Date: Fri Mar 7 11:50:15 2008 +0100
Turn off the annoying unpackaged file check
commit 899eb8a279994a987f911cac66f402507162d4ae
Author: Joel Andres Granados <jgranado@redhat.com>
Date: Thu Mar 6 22:08:55 2008 +0100
Create new plugin packages and add some automation to the makefile
|
| | |
|
| |
|
