1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
|
Planned changes to crash_data and dump_dir structures
Time field(s)
Need to add CD_FLAG_UNIXTIME bit for struct crash_item's flags field.
It should be set on cd["time"] item when we do
cd = call create_crash_data_from_dump_dir(dd);
Note that later we may add other elements beside "time" which contain
unix time.
Need to add a function which formats time elements for printing.
Something like this:
const char *printable_form_of_crash_item(const char *content, unsigned flags);
For most fields it should return them as-is, for CD_FLAG_UNIXTIME
fields it should return malloced "YYYY-MM-DD hh:mm:ss" string.
Later, if/when we will get more CD_FLAG_FOO flags, some of them also
may need special formatting, and this function can deal with them too.
[Implementation note: use the following trick to avoid needing to return
malloced data (which isn't convenient for caller, it needs to free it):
printable_form_of_crash_item(...)
{
...
if (need to use malloced string)
{
s = malloc_and_format_string();
static unsigned malloced_idx = 0;
static char *malloced_vec[8];
malloced_idx = (malloced_idx+1) % 8;
free(malloced_vec[malloced_idx]);
malloced_vec[malloced_idx] = s;
}
else
s = some_non_malloced_string;
...
return s;
}
]
dd_load_text_ext(dd, "time", flags) may benefit from a new flag DD_LOAD_TEXT_PRINTABLE,
which makes it generate printable representation of fields.
Reduce amount of special-casing in the code which works with crash_data
Examples:
Reporters use something like this to exclude "non-interesting" fields:
for (each crash_data element)
{
if (strcmp(short_name, FILENAME_COUNT) == 0) goto next;
if (strcmp(short_name, CD_DUMPDIR) == 0) goto next;
if (strcmp(short_name, FILENAME_INFORMALL) == 0) goto next;
if (strcmp(short_name, FILENAME_MESSAGE) == 0) goto next; // plugin's status message (if we already reported it yesterday)
...
}
write_crash_report_field(fp, report, FILENAME_COMMENT,
_("# Describe the circumstances of this crash below"));
write_crash_report_field(fp, report, FILENAME_REPRODUCE,
_("# How to reproduce the crash?"));
write_crash_report_field(fp, report, FILENAME_BACKTRACE,
_("# Backtrace\n# Check that it does not contain any sensitive data (passwords, etc.)"));
write_crash_report_field(fp, report, FILENAME_DUPHASH, "# DUPHASH");
write_crash_report_field(fp, report, FILENAME_ARCHITECTURE, _("# Architecture"));
write_crash_report_field(fp, report, FILENAME_CMDLINE, _("# Command line"));
write_crash_report_field(fp, report, FILENAME_COMPONENT, _("# Component"));
write_crash_report_field(fp, report, FILENAME_COREDUMP, _("# Core dump"));
write_crash_report_field(fp, report, FILENAME_EXECUTABLE, _("# Executable"));
write_crash_report_field(fp, report, FILENAME_KERNEL, _("# Kernel version"));
write_crash_report_field(fp, report, FILENAME_PACKAGE, _("# Package"));
write_crash_report_field(fp, report, FILENAME_REASON, _("# Reason of crash"));
write_crash_report_field(fp, report, FILENAME_OS_RELEASE, _("# Release string of the operating system"));
printf(_("Dump directory: %s\n"
"Last crash: %s\n"
"Analyzer: %s\n"
"Component: %s\n"
"Package: %s\n"
"Command: %s\n"
"Executable: %s\n"
"System: %s, kernel %s\n"
"Reason: %s\n"),
get_crash_item_content_or_die(crash_data, CD_DUMPDIR),
timeloc,
get_crash_item_content_or_die(crash_data, FILENAME_ANALYZER),
get_crash_item_content_or_die(crash_data, FILENAME_COMPONENT),
get_crash_item_content_or_die(crash_data, FILENAME_PACKAGE),
get_crash_item_content_or_die(crash_data, FILENAME_CMDLINE),
get_crash_item_content_or_die(crash_data, FILENAME_EXECUTABLE),
get_crash_item_content_or_die(crash_data, FILENAME_OS_RELEASE),
get_crash_item_content_or_die(crash_data, FILENAME_KERNEL),
get_crash_item_content_or_die(crash_data, FILENAME_REASON)
);
Can it be done better, so that we dont need to rewrite each of these places
every time we add a new field?
|
