summaryrefslogtreecommitdiffstats
path: root/lib/utils/dump_dir.c
Commit message (Collapse)AuthorAgeFilesLines
* move inc/ and lib/ to src/. No code changesDenys Vlasenko2010-11-151-504/+0
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* suppress open error message in one case when it isn't unexpectedDenys Vlasenko2010-11-041-7/+13
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* reduce usage of daemon's library in non-daemon partsDenys Vlasenko2010-10-251-1/+0
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* dump_dir: make open fail if there is no "analyzer" file.Denys Vlasenko2010-10-211-3/+20
| | | | | | | | | Also adjusts abrt-action-print to return better error message: '/tmp' is not a crash dump directory 1 Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* change dd_opendir API to return dd pointer (no need to dd_init it separately)Denys Vlasenko2010-10-151-28/+27
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* change dd_create API to return dd pointer (no need to dd_init it separately)Denys Vlasenko2010-10-151-26/+21
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Before this patch, dd_opendir(".") was creatingDenys Vlasenko2010-10-151-13/+40
| | | | | | | | | | | | | | | | | lock file "..lock", which is obviously wrong. This patch makes dd_opendir use realpath(dir_name). This makes dd_opendir(".") and similar cases correctly determine what is its parent directory and therefore use correct lock file name. dd_create can't use realpath, since it will always return NULL on not-yet existing directory. But this is not a problem, since dd_create(".") isn't a sane operation. So we continue to use old code. I only added a sanity check to refuse names ending in . and .. - just in case. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* various small fixes to dd usageDenys Vlasenko2010-10-141-49/+26
| | | | | | | | | | | KerneloopsScanner: dd leak on error path in save_oops_to_debug_dump() dump_dir: remove superfluous exist_file_dir check in dd_opendir, dd_create, delete_file_dir; use perror_msg instead of error_msg; correct some sligtly wrong log/error messages; make delete_file_dir return void, since return value is never checked. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* dump_dir.c: reorder functions within the file without changing them.Denys Vlasenko2010-10-141-64/+61
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* add two flags to dd_opendir()Nikola Pajkovsky2010-09-221-16/+10
| | | | | | | | | | | | | | | | | | | DD_CLOSE_ON_OPEN_ERR - free dump_dir structure when opening dump_dir does not exist DD_FAIL_QUIETLY - suppress message when dump directory does not exist VERB1 log(_("Unable to open debug dump '%s'"), pDebugDumpDir); is all removed because there is error_msg("'%s' does not exist", dd->dd_dir); in dd_opendir() which sometimes we don't want to print(DD_FAIL_QUIETLY) example: crash dump directory trimming code running concurrently. Second process may try to delete a directory which is already gone. it should not complain that it is missing. Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* unhide dump_dir structure from typedefNikola Pajkovsky2010-09-201-17/+17
| | | | | | no other code changes Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* dump_dir: added TODO comment. no code changesDenys Vlasenko2010-09-151-0/+20
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* fixing two instances of dd->gid which I forgot to convertDenys Vlasenko2010-09-141-2/+2
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* dump_dir: use dd_ prefix on uid/gid fieldsDenys Vlasenko2010-09-141-8/+8
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* I noticed that ->locked and ->opened members are always the sameDenys Vlasenko2010-09-141-80/+18
| | | | | | | | | | | | | (either 0 or 1), and I decided to drop ->opened. And do a few other trivial optimizations/cleanups. While working on it, I noticed that dd_save_binary has "opened" check inverted, and that dd_create and dd_open are leaking dd->dd_dir on error path. So the patch turned from optimization to bugfix. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* dump_dir: dd_close was freeing unallocated pointer! fix thatDenys Vlasenko2010-09-131-1/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* DebugDump.* -> dump_dir.*Nikola Pajkovsky2010-09-071-0/+535
Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Jiri Moskovcak <jmoskovc@redhat.com>