remove FILENAME_REPRODUCE field. FILENAME_COMMENT should be used instead

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>

11 files changed, 46 insertions, 148 deletions

diff --git a/src/cli/CLI.cpp b/src/cli/CLI.cpp
index 5ece3171..49c08279 100644
--- a/src/cli/CLI.cpp
+++ b/src/cli/CLI.cpp
@@ -182,10 +182,6 @@ static void print_crash_info(crash_data_t *crash_data, bool show_backtrace)
     if (hostname)
         printf(_("Hostname:           %s\n"), hostname);
 
-    const char *reproduce = get_crash_item_content_or_NULL(crash_data, FILENAME_REPRODUCE);
-    if (reproduce)
-        printf(_("\nHow to reproduce:\n%s\n"), reproduce);
-
     const char *comment = get_crash_item_content_or_NULL(crash_data, FILENAME_COMMENT);
     if (comment)
         printf(_("\nComment:\n%s\n"), comment);
diff --git a/src/cli/report.cpp b/src/cli/report.cpp
index 6b2bf2e2..ff18d19c 100644
--- a/src/cli/report.cpp
+++ b/src/cli/report.cpp
@@ -172,8 +172,6 @@ static void write_crash_report(crash_data_t *report, FILE *fp)
 
     write_crash_report_field(fp, report, FILENAME_COMMENT,
             _("# Describe the circumstances of this crash below"));
-    write_crash_report_field(fp, report, FILENAME_REPRODUCE,
-            _("# How to reproduce the crash?"));
     write_crash_report_field(fp, report, FILENAME_BACKTRACE,
             _("# Backtrace\n# Check that it does not contain any sensitive data (passwords, etc.)"));
     write_crash_report_field(fp, report, FILENAME_DUPHASH, "# DUPHASH");
@@ -255,7 +253,6 @@ static int read_crash_report(crash_data_t *report, const char *text)
 {
     int result = 0;
     result |= read_crash_report_field(text, report, FILENAME_COMMENT);
-    result |= read_crash_report_field(text, report, FILENAME_REPRODUCE);
     result |= read_crash_report_field(text, report, FILENAME_BACKTRACE);
     result |= read_crash_report_field(text, report, FILENAME_DUPHASH);
     result |= read_crash_report_field(text, report, FILENAME_ARCHITECTURE);
@@ -272,15 +269,12 @@ static int read_crash_report(crash_data_t *report, const char *text)
 
 /**
  * Ensures that the fields needed for editor are present in the crash data.
- * Fields: comments, how to reproduce.
+ * Fields: comments.
  */
 static void create_fields_for_editor(crash_data_t *crash_data)
 {
     if (!get_crash_data_item_or_NULL(crash_data, FILENAME_COMMENT))
         add_to_crash_data_ext(crash_data, FILENAME_COMMENT, "", CD_FLAG_TXT + CD_FLAG_ISEDITABLE);
-
-    if (!get_crash_data_item_or_NULL(crash_data, FILENAME_REPRODUCE))
-        add_to_crash_data_ext(crash_data, FILENAME_REPRODUCE, "1. \n2. \n3. \n", CD_FLAG_TXT + CD_FLAG_ISEDITABLE);
 }
 
 /**
@@ -725,18 +719,15 @@ int report(const char *dump_dir_name, int flags)
             free(events_as_lines);
             return 1;
         }
-        /* Save comment, "how to reproduce", backtrace */
+        /* Save comment, backtrace */
         dd = dd_opendir(dump_dir_name, /*flags:*/ 0);
         if (dd)
         {
 //TODO: we should iterate through crash_data and modify all modifiable fields
             const char *comment = get_crash_item_content_or_NULL(crash_data, FILENAME_COMMENT);
-            const char *reproduce = get_crash_item_content_or_NULL(crash_data, FILENAME_REPRODUCE);
             const char *backtrace = get_crash_item_content_or_NULL(crash_data, FILENAME_BACKTRACE);
             if (comment)
                 dd_save_text(dd, FILENAME_COMMENT, comment);
-            if (reproduce)
-                dd_save_text(dd, FILENAME_REPRODUCE, reproduce);
             if (backtrace)
                 dd_save_text(dd, FILENAME_BACKTRACE, backtrace);
             dd_close(dd);
diff --git a/src/daemon/CommLayerServerDBus.cpp b/src/daemon/CommLayerServerDBus.cpp
index 133feb7b..386b5872 100644
--- a/src/daemon/CommLayerServerDBus.cpp
+++ b/src/daemon/CommLayerServerDBus.cpp
@@ -219,7 +219,6 @@ static int handle_Report(DBusMessage* call, DBusMessage* reply)
     map_map_string_t user_conf_data;
     vector_string_t events;
     const char* comment = NULL;
-    const char* reproduce = NULL;
     const char* errmsg = NULL;
     DBusMessageIter in_iter;
 
@@ -235,15 +234,10 @@ static int handle_Report(DBusMessage* call, DBusMessage* reply)
     }
 //TODO? get_crash_item_content_or_die_or_empty?
     comment = get_crash_item_content_or_NULL(crash_data, FILENAME_COMMENT) ? : "";
-    reproduce = get_crash_item_content_or_NULL(crash_data, FILENAME_REPRODUCE) ? : "";
     if (strlen(comment) > LIMIT_MESSAGE)
     {
         errmsg = _("Comment is too long");
     }
-    else if (strlen(reproduce) > LIMIT_MESSAGE)
-    {
-        errmsg = _("'How to reproduce' is too long");
-    }
     if (errmsg)
     {
         dbus_message_unref(reply);
diff --git a/src/daemon/MiddleWare.cpp b/src/daemon/MiddleWare.cpp
index 2757d84f..809716aa 100644
--- a/src/daemon/MiddleWare.cpp
+++ b/src/daemon/MiddleWare.cpp
@@ -238,13 +238,12 @@ report_status_t Report(crash_data_t *client_report,
         }
     }
 
-    // Save comment, "how to reproduce", backtrace
+    // Save comment, backtrace
 //TODO: we should iterate through stored_report and modify all
 //modifiable fields which have new data in client_report
     const char *comment = get_crash_item_content_or_NULL(client_report, FILENAME_COMMENT);
-    const char *reproduce = get_crash_item_content_or_NULL(client_report, FILENAME_REPRODUCE);
     const char *backtrace = get_crash_item_content_or_NULL(client_report, FILENAME_BACKTRACE);
-    if (comment || reproduce || backtrace)
+    if (comment || backtrace)
     {
         struct dump_dir *dd = dd_opendir(dump_dir_name, /*flags:*/ 0);
         if (dd)
@@ -254,11 +253,6 @@ report_status_t Report(crash_data_t *client_report,
                 dd_save_text(dd, FILENAME_COMMENT, comment);
                 add_to_crash_data_ext(stored_report, FILENAME_COMMENT, comment, CD_FLAG_TXT + CD_FLAG_ISEDITABLE);
             }
-            if (reproduce)
-            {
-                dd_save_text(dd, FILENAME_REPRODUCE, reproduce);
-                add_to_crash_data_ext(stored_report, FILENAME_REPRODUCE, reproduce, CD_FLAG_TXT + CD_FLAG_ISEDITABLE);
-            }
             if (backtrace)
             {
                 dd_save_text(dd, FILENAME_BACKTRACE, backtrace);
diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index 27692925..2a41f366 100644
--- a/src/gui-wizard-gtk/wizard.c
+++ b/src/gui-wizard-gtk/wizard.c
@@ -19,7 +19,6 @@ GtkContainer *g_container_details2;
 
 GtkLabel *g_lbl_cd_reason;
 GtkTextView *g_tv_backtrace;
-GtkTextView *g_tv_reproduce;
 GtkTextView *g_tv_comment;
 GtkTreeView *g_tv_details;
 GtkListStore *g_ls_details;
@@ -335,7 +334,6 @@ void update_gui_state_from_crash_data(void)
     g_hash_table_foreach(g_cd, append_item_to_details_ls, NULL);
 
     load_text_to_text_view(g_tv_backtrace, FILENAME_BACKTRACE);
-    load_text_to_text_view(g_tv_reproduce, FILENAME_REPRODUCE);
     load_text_to_text_view(g_tv_comment, FILENAME_COMMENT);
 
 //Doesn't work: shows empty page
@@ -735,7 +733,6 @@ static void on_page_prepare(GtkAssistant *assistant, GtkWidget *page, gpointer u
     if (pages[PAGENO_REPORT].page_widget == page)
     {
         /* User just pressed [Fwd] on comment page. Same as above */
-        save_text_from_text_view(g_tv_reproduce, FILENAME_REPRODUCE);
         save_text_from_text_view(g_tv_comment, FILENAME_COMMENT);
     }
 
@@ -773,9 +770,7 @@ static gint next_page_no(gint current_page_no, gpointer data)
 
 #if 0
     case PAGENO_BACKTRACE_APPROVAL:
-        if (get_crash_item_content_or_NULL(g_cd, FILENAME_COMMENT)
-         || get_crash_item_content_or_NULL(g_cd, FILENAME_REPRODUCE)
-        ) {
+        if (get_crash_item_content_or_NULL(g_cd, FILENAME_COMMENT)) {
             break;
         }
         current_page_no++; /* no comment, skip next page */
@@ -919,7 +914,6 @@ static void add_pages(void)
     g_lbl_report_log       = GTK_LABEL(        gtk_builder_get_object(builder, "lbl_report_log"));
     g_tv_report_log        = GTK_TEXT_VIEW(    gtk_builder_get_object(builder, "tv_report_log"));
     g_tv_backtrace         = GTK_TEXT_VIEW(    gtk_builder_get_object(builder, "tv_backtrace"));
-    g_tv_reproduce         = GTK_TEXT_VIEW(    gtk_builder_get_object(builder, "tv_reproduce"));
     g_tv_comment           = GTK_TEXT_VIEW(    gtk_builder_get_object(builder, "tv_comment"));
     g_tv_details           = GTK_TREE_VIEW(    gtk_builder_get_object(builder, "tv_details"));
     g_box_warning_labels   = GTK_BOX(          gtk_builder_get_object(builder, "box_warning_labels"));
diff --git a/src/gui-wizard-gtk/wizard.glade b/src/gui-wizard-gtk/wizard.glade
index 0db515d2..e35f5e15 100644
--- a/src/gui-wizard-gtk/wizard.glade
+++ b/src/gui-wizard-gtk/wizard.glade
@@ -387,92 +387,47 @@
         <property name="border_width">10</property>
         <property name="orientation">vertical</property>
         <child>
-          <object class="GtkVBox" id="vbox1">
+          <object class="GtkLabel" id="label2">
             <property name="visible">True</property>
-            <property name="orientation">vertical</property>
-            <property name="spacing">5</property>
-            <child>
-              <object class="GtkVBox" id="vbox3">
-                <property name="visible">True</property>
-                <property name="orientation">vertical</property>
-                <child>
-                  <object class="GtkLabel" id="label1">
-                    <property name="visible">True</property>
-                    <property name="xalign">1.1175871339474952e-09</property>
-                    <property name="yalign">0</property>
-                    <property name="ypad">5</property>
-                    <property name="label" translatable="yes">How did this crash happen (step-by-step)? How can it be reproduced?</property>
-                  </object>
-                  <packing>
-                    <property name="expand">False</property>
-                    <property name="position">0</property>
-                  </packing>
-                </child>
-                <child>
-                  <object class="GtkScrolledWindow" id="scrolledwindow3">
-                    <property name="visible">True</property>
-                    <property name="can_focus">True</property>
-                    <property name="hscrollbar_policy">automatic</property>
-                    <property name="vscrollbar_policy">automatic</property>
-                    <child>
-                      <object class="GtkTextView" id="tv_reproduce">
-                        <property name="visible">True</property>
-                        <property name="can_focus">True</property>
-                        <property name="wrap_mode">word</property>
-                      </object>
-                    </child>
-                  </object>
-                  <packing>
-                    <property name="position">1</property>
-                  </packing>
-                </child>
-              </object>
-              <packing>
-                <property name="position">0</property>
-              </packing>
-            </child>
+            <property name="xalign">0</property>
+            <property name="yalign">0</property>
+            <property name="ypad">5</property>
+            <property name="label" translatable="yes">How did this problem happen (step-by-step)? How can it be reproduced?</property>
+          </object>
+          <packing>
+            <property name="expand">False</property>
+            <property name="position">0</property>
+          </packing>
+        </child>
+        <child>
+          <object class="GtkLabel" id="label1">
+            <property name="visible">True</property>
+            <property name="xalign">0</property>
+            <property name="yalign">0</property>
+            <property name="ypad">5</property>
+            <property name="label" translatable="yes">Any additional comments useful for diagnosing the problem?</property>
+          </object>
+          <packing>
+            <property name="expand">False</property>
+            <property name="position">1</property>
+          </packing>
+        </child>
+        <child>
+          <object class="GtkScrolledWindow" id="scrolledwindow4">
+            <property name="visible">True</property>
+            <property name="can_focus">True</property>
+            <property name="hscrollbar_policy">automatic</property>
+            <property name="vscrollbar_policy">automatic</property>
             <child>
-              <object class="GtkVBox" id="vbox4">
+              <object class="GtkTextView" id="tv_comment">
                 <property name="visible">True</property>
-                <property name="orientation">vertical</property>
-                <child>
-                  <object class="GtkLabel" id="label2">
-                    <property name="visible">True</property>
-                    <property name="xalign">0</property>
-                    <property name="yalign">0</property>
-                    <property name="label" translatable="yes">Are there any comments you would like to share with the software maintainers?</property>
-                  </object>
-                  <packing>
-                    <property name="expand">False</property>
-                    <property name="position">0</property>
-                  </packing>
-                </child>
-                <child>
-                  <object class="GtkScrolledWindow" id="scrolledwindow4">
-                    <property name="visible">True</property>
-                    <property name="can_focus">True</property>
-                    <property name="hscrollbar_policy">automatic</property>
-                    <property name="vscrollbar_policy">automatic</property>
-                    <child>
-                      <object class="GtkTextView" id="tv_comment">
-                        <property name="visible">True</property>
-                        <property name="can_focus">True</property>
-                        <property name="wrap_mode">word</property>
-                      </object>
-                    </child>
-                  </object>
-                  <packing>
-                    <property name="position">1</property>
-                  </packing>
-                </child>
+                <property name="can_focus">True</property>
+                <property name="wrap_mode">word</property>
               </object>
-              <packing>
-                <property name="position">1</property>
-              </packing>
             </child>
           </object>
           <packing>
-            <property name="position">0</property>
+            <property name="position">2</property>
           </packing>
         </child>
         <child>
@@ -486,7 +441,7 @@
           </object>
           <packing>
             <property name="expand">False</property>
-            <property name="position">1</property>
+            <property name="position">3</property>
           </packing>
         </child>
       </object>
diff --git a/src/include/abrt_crash_data.h b/src/include/abrt_crash_data.h
index b71b046f..2a123ec3 100644
--- a/src/include/abrt_crash_data.h
+++ b/src/include/abrt_crash_data.h
@@ -52,7 +52,6 @@
 #define FILENAME_PACKAGE      "package"
 #define FILENAME_COMPONENT    "component"
 #define FILENAME_COMMENT      "comment"
-#define FILENAME_REPRODUCE    "reproduce"
 #define FILENAME_RATING       "rating"
 #define FILENAME_HOSTNAME     "hostname"
 // Optional. Set to "1" by abrt-handle-upload for every unpacked crashdump
diff --git a/src/include/abrtlib.h b/src/include/abrtlib.h
index 61731587..116f4b36 100644
--- a/src/include/abrtlib.h
+++ b/src/include/abrtlib.h
@@ -229,8 +229,8 @@ char *iso_date_string(time_t *pt);
 
 #define make_description_bz abrt_make_description_bz
 char* make_description_bz(crash_data_t *crash_data);
-#define make_description_reproduce_comment abrt_make_description_reproduce_comment
-char* make_description_reproduce_comment(crash_data_t *crash_data);
+#define make_description_comment abrt_make_description_comment
+char* make_description_comment(crash_data_t *crash_data);
 #define make_description_logger abrt_make_description_logger
 char* make_description_logger(crash_data_t *crash_data);
 #define make_description_mailx abrt_make_description_mailx
diff --git a/src/lib/crash_data.c b/src/lib/crash_data.c
index 1ae8f4f1..8c948436 100644
--- a/src/lib/crash_data.c
+++ b/src/lib/crash_data.c
@@ -89,7 +89,6 @@ vector_of_crash_data_t *new_vector_of_crash_data(void)
 
 static const char *const editable_files[] = {
 	FILENAME_COMMENT    ,
-	FILENAME_REPRODUCE  ,
 	FILENAME_BACKTRACE  ,
 	NULL
 };
diff --git a/src/lib/make_descr.c b/src/lib/make_descr.c
index 1ba15203..1ebdfc4d 100644
--- a/src/lib/make_descr.c
+++ b/src/lib/make_descr.c
@@ -140,20 +140,13 @@ char* make_description_bz(crash_data_t *crash_data)
             }
             if (*bl)
                 continue; /* blacklisted */
-            if (strcmp(content, "1.\n2.\n3.\n") == 0)
-                continue; /* user did not change default "How to reproduce" */
 
             if (strlen(content) <= CD_TEXT_ATT_SIZE)
             {
                 /* Add small (less than few kb) text items inline */
                 bool was_multiline = 0;
                 char *tmp = NULL;
-                add_content(&was_multiline,
-                        &tmp,
-			/* "reproduce: blah" looks ugly, fixing: */
-                        (strcmp(name, FILENAME_REPRODUCE) == 0) ? "How to reproduce" : name,
-                        content
-                );
+                add_content(&was_multiline, &tmp, name, content);
 
                 if (was_multiline)
                 {
@@ -233,8 +226,6 @@ char* make_description_logger(crash_data_t *crash_data)
             }
             if (*bl)
                 continue; /* blacklisted */
-            if (strcmp(content, "1.\n2.\n3.\n") == 0)
-                continue; /* user did not change default "How to reproduce" */
 
             bool was_multiline = 0;
             char *tmp = NULL;
@@ -262,22 +253,11 @@ char* make_description_logger(crash_data_t *crash_data)
     return strbuf_free_nobuf(buf_dsc);
 }
 
-char* make_description_reproduce_comment(crash_data_t *crash_data)
+char* make_description_comment(crash_data_t *crash_data)
 {
-    char *repro = NULL;
     char *comment = NULL;
     struct crash_item *value;
 
-    value = get_crash_data_item_or_NULL(crash_data, FILENAME_REPRODUCE);
-    if (value)
-    {
-        if (value->content[0]
-         && strcmp(value->content, "1.\n2.\n3.\n") != 0
-        ) {
-            repro = xasprintf("\n\nHow to reproduce\n-----\n%s", value->content);
-        }
-    }
-
     value = get_crash_data_item_or_NULL(crash_data, FILENAME_COMMENT);
     if (value)
     {
@@ -285,18 +265,14 @@ char* make_description_reproduce_comment(crash_data_t *crash_data)
             comment = xasprintf("\n\nComment\n-----\n%s", value->content);
     }
 
-    if (!repro && !comment)
+    if (!comment)
         return NULL;
 
     struct strbuf *buf_dsc = strbuf_new();
 
-    if (repro)
-        strbuf_append_str(buf_dsc, repro);
-
     if (comment)
         strbuf_append_str(buf_dsc, comment);
 
-    free(repro);
     free(comment);
 
     return strbuf_free_nobuf(buf_dsc);
diff --git a/src/plugins/abrt-action-bugzilla.cpp b/src/plugins/abrt-action-bugzilla.cpp
index 2aa32b75..1a391ae9 100644
--- a/src/plugins/abrt-action-bugzilla.cpp
+++ b/src/plugins/abrt-action-bugzilla.cpp
@@ -854,7 +854,7 @@ static void report_to_bugzilla(
             throw_if_xml_fault_occurred(&bz_server.env);
         }
 
-        char *dsc = make_description_reproduce_comment(crash_data);
+        char *dsc = make_description_comment(crash_data);
         if (dsc)
         {
             const char* package    = get_crash_item_content_or_NULL(crash_data, FILENAME_PACKAGE);