This patch changes crash data to use C structures.

The smallest data element is:

struct crash_item { char *content; unsigned flags; };

where content is, eh, content, and flags is a bit flag field.

crash_data_t is a map of crash_item's, implemented as a pointer
to heap-allocated GHashTable.

vector_of_crash_data_t is a vector of crash_data_t's, implemented
as a pointer to heap-allocated GPtrArray.

Most operations have light wrappers around them to hide the nature
of the containers. For example, to free vector_of_crash_data,
you need to use free_vector_of_crash_data(ptr) instead of
open-coding g_ptr_array_free. The wrapper is thin.

The goal is not so much to hide the implementation, but more
to make it easier to use the correct function.

dbus (un)marshalling functions convert crash_item to three-element
array of strings, in order to keep compatibility with abrt-gui (python).
This can be changed later to use native representation.
crash_data_t and vector_of_crash_data_t are represented in
"natural" way, no funny stuff there.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/plugins/abrt-action-print.cpp b/src/plugins/abrt-action-print.cpp
index 303c05f7..04d01de3 100644
--- a/src/plugins/abrt-action-print.cpp
+++ b/src/plugins/abrt-action-print.cpp
@@ -81,13 +81,13 @@ int main(int argc, char **argv)
         if (!dd)
             return 1; /* error message is already logged */
 
-        map_crash_data_t pCrashData;
-        load_crash_data_from_crash_dump_dir(dd, pCrashData);
+        crash_data_t *crash_data = load_crash_data_from_crash_dump_dir(dd);
         dd_close(dd);
 
-        char *dsc = make_description_logger(pCrashData);
+        char *dsc = make_description_logger(crash_data);
         fputs(dsc, stdout);
         free(dsc);
+        free_crash_data(crash_data);
     }
     catch (CABRTException& e)
     {