assorted cleanups, memory leak fix (g_list_free in add_basics_to_problem_data)

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>

1 files changed, 2 insertions, 13 deletions

diff --git a/src/plugins/abrt-action-analyze-c.c b/src/plugins/abrt-action-analyze-c.c
index 487fb8f7..240ca2a2 100644
--- a/src/plugins/abrt-action-analyze-c.c
+++ b/src/plugins/abrt-action-analyze-c.c
@@ -21,24 +21,13 @@
 
 static void create_hash(char hash_str[SHA1_RESULT_LEN*2 + 1], const char *pInput)
 {
-    unsigned char hash_bytes[SHA1_RESULT_LEN];
-
+    char hash_bytes[SHA1_RESULT_LEN];
     sha1_ctx_t sha1ctx;
     sha1_begin(&sha1ctx);
     sha1_hash(&sha1ctx, pInput, strlen(pInput));
     sha1_end(&sha1ctx, hash_bytes);
 
-    unsigned len = SHA1_RESULT_LEN;
-    unsigned char *s = hash_bytes;
-    char *d = hash_str;
-    while (len)
-    {
-        *d++ = "0123456789abcdef"[*s >> 4];
-        *d++ = "0123456789abcdef"[*s & 0xf];
-        s++;
-        len--;
-    }
-    *d = '\0';
+    bin2hex(hash_str, hash_bytes, SHA1_RESULT_LEN)[0] = '\0';
     //log("hash:%s str:'%s'", hash_str, pInput);
 }