Settings.cpp: avoid double free corruption

I meant, that settings_free() should not only do
    free(g_settings_*);
but also should do
    g_settings_* = NULL;

Otherwise calling settings_free() twice will cause double-free
and likely segfault.

Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>

1 files changed, 5 insertions, 0 deletions

diff --git a/src/daemon/Settings.cpp b/src/daemon/Settings.cpp
index f7b7d2ef..a85bb419 100644
--- a/src/daemon/Settings.cpp
+++ b/src/daemon/Settings.cpp
@@ -571,18 +571,23 @@ void settings_free()
         free((char*)li->data);
 
     g_list_free(g_settings_setOpenGPGPublicKeys);
+    g_settings_setOpenGPGPublicKeys = NULL;
 
     for (GList *li = g_settings_setBlackListedPkgs; li != NULL; li = g_list_next(li))
         free((char*)li->data);
 
     g_list_free(g_settings_setBlackListedPkgs);
+    g_settings_setBlackListedPkgs = NULL;
 
     for (GList *li = g_settings_setBlackListedPaths; li != NULL; li = g_list_next(li))
         free((char*)li->data);
 
     g_list_free(g_settings_setBlackListedPaths);
+    g_settings_setBlackListedPaths = NULL;
 
     free(g_settings_sDatabase);
+    g_settings_sDatabase = NULL;
 
     free(g_settings_sWatchCrashdumpArchiveDir);
+    g_settings_sWatchCrashdumpArchiveDir = NULL;
 }