diff options
| author | Denys Vlasenko <vda.linux@googlemail.com> | 2009-09-24 16:43:31 +0200 |
|---|---|---|
| committer | Denys Vlasenko <vda.linux@googlemail.com> | 2009-09-24 16:43:31 +0200 |
| commit | 42da1ce16cd602b8387a4672cd42b0799a1a1284 (patch) | |
| tree | 76efdd140ea256457924570dff50ce562f980cd4 /src/CLI/CLI.cpp | |
| parent | eff2909c3bda95c32b30726685988d357cf4a320 (diff) | |
| download | abrt-42da1ce16cd602b8387a4672cd42b0799a1a1284.tar.gz abrt-42da1ce16cd602b8387a4672cd42b0799a1a1284.tar.xz abrt-42da1ce16cd602b8387a4672cd42b0799a1a1284.zip | |
abrtd: add an optional 2nd parameter to Report dbus call
Also, simplified dbus code a bit.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'src/CLI/CLI.cpp')
| -rw-r--r-- | src/CLI/CLI.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/CLI/CLI.cpp b/src/CLI/CLI.cpp index 1fd09301..3c38508b 100644 --- a/src/CLI/CLI.cpp +++ b/src/CLI/CLI.cpp @@ -92,8 +92,7 @@ static vector_crash_infos_t call_GetCrashInfos() vector_crash_infos_t argout; DBusMessageIter in_iter; - if (!dbus_message_iter_init(reply, &in_iter)) /* no values */ - error_msg_and_die("dbus call %s: return type mismatch", "GetCrashInfos"); + dbus_message_iter_init(reply, &in_iter); int r = load_val(&in_iter, argout); if (r != ABRT_DBUS_LAST_FIELD) /* more values present, or bad type */ error_msg_and_die("dbus call %s: return type mismatch", "GetCrashInfos"); @@ -103,6 +102,8 @@ static vector_crash_infos_t call_GetCrashInfos() static map_crash_report_t call_CreateReport(const char* uuid) { + /* Yes, call name is not "CreateReport" but "GetJobResult". + * We need to clean up the names one day. */ DBusMessage* msg = new_call_msg("GetJobResult"); dbus_message_append_args(msg, DBUS_TYPE_STRING, &uuid, @@ -112,8 +113,7 @@ static map_crash_report_t call_CreateReport(const char* uuid) map_crash_report_t argout; DBusMessageIter in_iter; - if (!dbus_message_iter_init(reply, &in_iter)) /* no values */ - error_msg_and_die("dbus call %s: return type mismatch", "GetJobResult"); + dbus_message_iter_init(reply, &in_iter); int r = load_val(&in_iter, argout); if (r != ABRT_DBUS_LAST_FIELD) /* more values present, or bad type */ error_msg_and_die("dbus call %s: return type mismatch", "GetJobResult"); |