add two flags to dd_opendir()

DD_CLOSE_ON_OPEN_ERR - free dump_dir structure when opening dump_dir
does not exist

DD_FAIL_QUIETLY - suppress message when dump directory does not exist

VERB1 log(_("Unable to open debug dump '%s'"), pDebugDumpDir); is all
removed because there is error_msg("'%s' does not exist", dd->dd_dir);
in dd_opendir() which sometimes we don't want to print(DD_FAIL_QUIETLY)

example: crash dump directory trimming code running concurrently.
Second process may try to delete
a directory which is already gone. it should not complain
that it is missing.

Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
Acked-off-by: Denys Vlasenko <dvlasenk@redhat.com>

1 files changed, 1 insertions, 5 deletions

diff --git a/lib/plugins/RunApp.cpp b/lib/plugins/RunApp.cpp
index 0bf5ff0c..3ae6638b 100644
--- a/lib/plugins/RunApp.cpp
+++ b/lib/plugins/RunApp.cpp
@@ -58,12 +58,8 @@ void CActionRunApp::Run(const char *pActionDir, const char *pArgs, int force)
     if (args.size() > FILENAME)
     {
         struct dump_dir *dd = dd_init();
-        if (!dd_opendir(dd, pActionDir))
-        {
-            dd_close(dd);
-            VERB1 log(_("Unable to open debug dump '%s'"), pActionDir);
+        if (!dd_opendir(dd, pActionDir, DD_CLOSE_ON_OPEN_ERR))
             return;
-        }
 
         dd_save_binary(dd, args[FILENAME].c_str(), cmd_out, cmd_out_size);
         dd_close(dd);