*: UID:UUID -> crash_id conversion

This fixes at least three instances where we did not check whether
user is even allowed to report or delete a crash.

Also fixes a few cases when root might inadvertently act on (e.g. delete)
mote than one crash.

Renamed FILENAME_UID to CD_UID - makes more sense this way.
Added COL_INFORMALL and CD_INFORMALL. Nuked UID == -1 hacks.
Renamed getReport() to start_job on Python side.
Dropped a few unused parameters from server -> client dbus signals.
Fixed CLI's way of reverencing crashes (see updated help text).

Run-tested (GUI and CLI).

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Acked-by: Nikola Pajkovsky <npajkovs@redhat.com>

1 files changed, 7 insertions, 9 deletions

diff --git a/lib/Plugins/SQLite3.h b/lib/Plugins/SQLite3.h
index 94cb0422..b9dc9e7f 100644
--- a/lib/Plugins/SQLite3.h
+++ b/lib/Plugins/SQLite3.h
@@ -37,20 +37,18 @@ class CSQLite3 : public CDatabase
         virtual void Connect();
         virtual void DisConnect();
 
-        virtual void Insert_or_Update(const char *pUUID,
-                        const char *pUID,
+        virtual void Insert_or_Update(const char *crash_id,
+                        bool inform_all_users,
                         const char *pDebugDumpPath,
                         const char *pTime);
-
-        virtual void DeleteRow(const char *pUUID, const char *pUID);
+        virtual void DeleteRow(const char *crash_id);
         virtual void DeleteRows_by_dir(const char *dump_dir);
-        virtual void SetReported(const char *pUUID, const char *pUID, const char *pMessage);
-        virtual void SetReportedPerReporter(const char *pUUID,
-                                 const char *pUID,
+        virtual void SetReported(const char *crash_id, const char *pMessage);
+        virtual void SetReportedPerReporter(const char *crash_id,
                                  const char *reporter,
                                  const char *pMessage);
-        virtual vector_database_rows_t GetUIDData(const char *pUID);
-        virtual database_row_t GetRow(const char *pUUID, const char *pUID);
+        virtual vector_database_rows_t GetUIDData(long caller_uid);
+        virtual database_row_t GetRow(const char *crash_id);
 
         virtual void SetSettings(const map_plugin_settings_t& pSettings);
 };