diff options
| author | Denys Vlasenko <dvlasenk@redhat.com> | 2010-09-14 17:09:50 +0200 |
|---|---|---|
| committer | Denys Vlasenko <dvlasenk@redhat.com> | 2010-09-14 17:09:50 +0200 |
| commit | e2fd97d5c8d1c64ee1e09b966f38c33ad1a1fa48 (patch) | |
| tree | b189f48af3472c5794abb698d6ad8eee843c3ec6 /inc | |
| parent | d75496e3e1bc3461c5a43fd622bdc5f097613972 (diff) | |
| download | abrt-e2fd97d5c8d1c64ee1e09b966f38c33ad1a1fa48.tar.gz abrt-e2fd97d5c8d1c64ee1e09b966f38c33ad1a1fa48.tar.xz abrt-e2fd97d5c8d1c64ee1e09b966f38c33ad1a1fa48.zip | |
I noticed that ->locked and ->opened members are always the same
(either 0 or 1), and I decided to drop ->opened.
And do a few other trivial optimizations/cleanups.
While working on it, I noticed that dd_save_binary has "opened"
check inverted, and that dd_create and dd_open are leaking
dd->dd_dir on error path.
So the patch turned from optimization to bugfix.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Diffstat (limited to 'inc')
| -rw-r--r-- | inc/dump_dir.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/inc/dump_dir.h b/inc/dump_dir.h index 96d50d35..a476ec06 100644 --- a/inc/dump_dir.h +++ b/inc/dump_dir.h @@ -29,7 +29,6 @@ extern "C" { typedef struct dump_dir { char *dd_dir; DIR *next_dir; - int opened; int locked; uid_t uid; gid_t gid; @@ -41,7 +40,7 @@ void dd_close(dump_dir_t *dd); int dd_opendir(dump_dir_t *dd, const char *dir); int dd_exist(dump_dir_t *dd, const char *path); int dd_create(dump_dir_t *dd, const char *dir, uid_t uid); -int dd_init_next_file(dump_dir_t *dd); +DIR *dd_init_next_file(dump_dir_t *dd); int dd_get_next_file(dump_dir_t *dd, char **short_name, char **full_name); char* dd_load_text(const dump_dir_t *dd, const char* name); |