summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenys Vlasenko <dvlasenk@redhat.com>2010-11-22 14:42:49 +0100
committerDenys Vlasenko <dvlasenk@redhat.com>2010-11-22 14:42:49 +0100
commit4bb97934558b6b6a1aafdfe3bc56c38dc3b79c87 (patch)
tree5f54190a5a898bb6561ed9065664c9557a143f5b
parent0903a40ead07db5b8c4d73fff4e8d7d3f9c7fcd9 (diff)
downloadabrt-4bb97934558b6b6a1aafdfe3bc56c38dc3b79c87.tar.gz
abrt-4bb97934558b6b6a1aafdfe3bc56c38dc3b79c87.tar.xz
abrt-4bb97934558b6b6a1aafdfe3bc56c38dc3b79c87.zip
Improve some comments. No code changes
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
-rw-r--r--src/daemon/abrt_event.conf4
-rw-r--r--src/plugins/CCpp.cpp16
2 files changed, 13 insertions, 7 deletions
diff --git a/src/daemon/abrt_event.conf b/src/daemon/abrt_event.conf
index 58126192..6c1ac191 100644
--- a/src/daemon/abrt_event.conf
+++ b/src/daemon/abrt_event.conf
@@ -40,6 +40,10 @@ EVENT=post-create analyzer=Kerneloops abrt-action-analyze-oops
#TODO: implement this (or add this functionality to abrt-action-install-debuginfo):
#EVENT=analyze analyzer=CCpp backtrace= trim-debuginfo-cache /var/cache/abrt-di 4096m
+# Additional directories to search for debuginfos can be specified
+# in the third argument (its format is CACHEDIR[:DEBUGINFODIR...]).
+# For example, you can specify a network-mounted shared store
+# of all debuginfos this way.
EVENT=analyze analyzer=CCpp backtrace= abrt-action-install-debuginfo "$DUMP_DIR/coredump" "/var/run/abrt/$$-$RANDOM" /var/cache/abrt-di
EVENT=analyze analyzer=CCpp backtrace= abrt-action-generate-backtrace
diff --git a/src/plugins/CCpp.cpp b/src/plugins/CCpp.cpp
index fad9cf62..44550ed6 100644
--- a/src/plugins/CCpp.cpp
+++ b/src/plugins/CCpp.cpp
@@ -31,13 +31,15 @@ using namespace std;
#define CORE_PATTERN "|"CCPP_HOOK_PATH" "DEBUG_DUMPS_DIR" %p %s %u %c"
#define CORE_PIPE_LIMIT_IFACE "/proc/sys/kernel/core_pipe_limit"
/* core_pipe_limit specifies how many dump_helpers might run at the same time
-0 - means unlimited, but the it's not guaranteed that /proc/<pid> of crashing
-process might not be available for dump_helper
-4 - means that 4 dump_helpers can run at the same time, which should be enough
-for ABRT, we can miss some crashes, but what are the odds that more processes
-crash at the same time? This value has been recommended by nhorman
-*/
-#define CORE_PIPE_LIMIT "4"
+ * 0 - means unlimited, but it's not guaranteed that /proc/<pid> of crashing
+ * process will be available for dump_helper
+ * 4 - means that 4 dump_helpers can run at the same time (the rest will also
+ * run, but they will fail to read /proc/<pid>)
+ * This should be enough for ABRT, we can miss some crashes, but what are
+ * the odds that more processes crash at the same time?
+ * The value of 4 has been recommended by nhorman.
+ */
+#define CORE_PIPE_LIMIT "4"
#define DEBUGINFO_CACHE_DIR LOCALSTATEDIR"/cache/abrt-di"