summaryrefslogtreecommitdiffstats
path: root/daemons
diff options
context:
space:
mode:
authorSimo Sorce <simo@redhat.com>2013-08-27 09:24:32 -0400
committerPetr Viktorin <pviktori@redhat.com>2013-08-28 12:42:56 +0200
commitf96257397e8f1cb8a307e6ec0e48bd3570a16671 (patch)
tree2c9efc75e6aff6e1fd09b32fe9e52198c235df86 /daemons
parentb29ce207054672844909069625e50c61deceacb7 (diff)
downloadfreeipa-f96257397e8f1cb8a307e6ec0e48bd3570a16671.tar.gz
freeipa-f96257397e8f1cb8a307e6ec0e48bd3570a16671.tar.xz
freeipa-f96257397e8f1cb8a307e6ec0e48bd3570a16671.zip
kdb-mspac: Fix out of bounds memset
This memset was harmless as the following data is then set again, but an optimizing compiler might conceivably reorder instructions causing issues. CoverityID: 11909 Fixes: https://fedorahosted.org/freeipa/ticket/3883
Diffstat (limited to 'daemons')
-rw-r--r--daemons/ipa-kdb/ipa_kdb_mspac.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/daemons/ipa-kdb/ipa_kdb_mspac.c b/daemons/ipa-kdb/ipa_kdb_mspac.c
index 32e6ca36..ac6a6eb6 100644
--- a/daemons/ipa-kdb/ipa_kdb_mspac.c
+++ b/daemons/ipa-kdb/ipa_kdb_mspac.c
@@ -775,7 +775,7 @@ static krb5_error_code ipadb_fill_info3(struct ipadb_context *ipactx,
}
/* always zero out, not used for Krb, only NTLM */
- memset(&info3->base.LMSessKey, '\0', sizeof(info3->base.key));
+ memset(&info3->base.LMSessKey, '\0', sizeof(info3->base.LMSessKey));
/* TODO: fill based on objectclass, user vs computer, etc... */
info3->base.acct_flags = ACB_NORMAL; /* samr_AcctFlags */