summaryrefslogtreecommitdiffstats
path: root/runtime/queue.c
diff options
context:
space:
mode:
authorRainer Gerhards <rgerhards@adiscon.com>2009-10-26 10:09:04 +0100
committerRainer Gerhards <rgerhards@adiscon.com>2009-10-26 10:09:04 +0100
commit6be07a8f8a3b9b7baf77e42639473e9b1a990e29 (patch)
treedade763f274a4a035cd6fed684c7eeb17599e37e /runtime/queue.c
parenteb5cb72ec4cb4ac5d7f13855ac4dac9b6927078c (diff)
downloadrsyslog-6be07a8f8a3b9b7baf77e42639473e9b1a990e29.tar.gz
rsyslog-6be07a8f8a3b9b7baf77e42639473e9b1a990e29.tar.xz
rsyslog-6be07a8f8a3b9b7baf77e42639473e9b1a990e29.zip
bugfix: potential abort if inputname property was not set
primarily a problem of imdiag. Also added some fix for a potential situation during cancel processing. That one is not considered vital and may later be removed again.
Diffstat (limited to 'runtime/queue.c')
-rw-r--r--runtime/queue.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/runtime/queue.c b/runtime/queue.c
index 4bbcc2b8..67bc40c2 100644
--- a/runtime/queue.c
+++ b/runtime/queue.c
@@ -1612,18 +1612,21 @@ RateLimiter(qqueue_t *pThis)
}
-/* This dequeues the next batch.
+/* This dequeues the next batch. Note that this function must not be
+ * cancelled, else it will leave back an inconsistent state.
* rgerhards, 2009-05-20
*/
static inline rsRetVal
DequeueForConsumer(qqueue_t *pThis, wti_t *pWti)
{
+ int iCancelStateSave;
DEFiRet;
ISOBJ_TYPE_assert(pThis, qqueue);
ISOBJ_TYPE_assert(pWti, wti);
dbgprintf("YYY: dequeue for consumer\n");
+ pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &iCancelStateSave);
CHKiRet(DequeueConsumable(pThis, pWti));
if(pWti->batch.nElem == 0)
@@ -1631,6 +1634,7 @@ dbgprintf("YYY: dequeue for consumer\n");
finalize_it:
+ pthread_setcancelstate(iCancelStateSave, NULL);
RETiRet;
}