diff options
| author | Rainer Gerhards <rgerhards@adiscon.com> | 2011-02-23 08:54:31 +0100 |
|---|---|---|
| committer | Rainer Gerhards <rgerhards@adiscon.com> | 2011-02-23 08:54:31 +0100 |
| commit | e867cb41372e9b8e08b8eec0d663a1f3ccea5367 (patch) | |
| tree | 87c2414eb0b5e7d0c7702fb498bd735ca6f2fd7b | |
| parent | 095a7ec73883ff14ff428653a5fa153892c1497a (diff) | |
| download | rsyslog-e867cb41372e9b8e08b8eec0d663a1f3ccea5367.tar.gz rsyslog-e867cb41372e9b8e08b8eec0d663a1f3ccea5367.tar.xz rsyslog-e867cb41372e9b8e08b8eec0d663a1f3ccea5367.zip | |
added debug support for trying to find well-hidden bug
| -rw-r--r-- | runtime/msg.c | 10 | ||||
| -rw-r--r-- | runtime/msg.h | 3 |
2 files changed, 12 insertions, 1 deletions
diff --git a/runtime/msg.c b/runtime/msg.c index e8be79db..fb4d5742 100644 --- a/runtime/msg.c +++ b/runtime/msg.c @@ -677,6 +677,7 @@ static inline rsRetVal msgBaseConstruct(msg_t **ppThis) /* initialize members in ORDER they appear in structure (think "cache line"!) */ pM->flowCtlType = 0; pM->bDoLock = 0; + pM->bAlreadyFreed = 0; pM->iRefCount = 1; pM->iSeverity = -1; pM->iFacility = -1; @@ -803,6 +804,15 @@ CODESTARTobjDestruct(msg) if(currRefCount == 0) { /* DEV Debugging Only! dbgprintf("msgDestruct\t0x%lx, RefCount now 0, doing DESTROY\n", (unsigned long)pThis); */ + /* The if below is included to try to nail down a well-hidden bug causing + * segfaults. I hope that do to the test code the problem is sooner detected and + * thus we get better data for debugging and resolving it. -- rgerhards, 2011-02-23. + * TODO: remove when no longer needed. + */ + if(pThis->bAlreadyFreed) + abort(); + pThis->bAlreadyFreed = 1; + /* end debug code */ if(pThis->pszRawMsg != pThis->szRawMsg) free(pThis->pszRawMsg); freeTAG(pThis); diff --git a/runtime/msg.h b/runtime/msg.h index 4897959c..26a07aca 100644 --- a/runtime/msg.h +++ b/runtime/msg.h @@ -61,7 +61,8 @@ struct msg { once data has entered the queue, this property is no longer needed. */ pthread_mutex_t mut; int iRefCount; /* reference counter (0 = unused) */ - sbool bDoLock; /* use the mutex? */ + sbool bDoLock; /* use the mutex? */ + sbool bAlreadyFreed; /* aid to help detect a well-hidden bad bug -- TODO: remove when no longer needed */ short iSeverity; /* the severity 0..7 */ short iFacility; /* Facility code 0 .. 23*/ short offAfterPRI; /* offset, at which raw message WITHOUT PRI part starts in pszRawMsg */ |