summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiloslav Trmač <mitr@redhat.com>2012-07-18 15:35:56 +0200
committerMiloslav Trmač <mitr@redhat.com>2012-07-18 15:38:26 +0200
commit923860fc017adb562f4d0fae5dc67f137236ed39 (patch)
treec9a0328583a2ad8f9a897d49bf7a30d11875163d
parentb9a8a0253a68d8622962bbf98505824ebbcd4656 (diff)
downloadlibumberlog-923860fc017adb562f4d0fae5dc67f137236ed39.tar.gz
libumberlog-923860fc017adb562f4d0fae5dc67f137236ed39.tar.xz
libumberlog-923860fc017adb562f4d0fae5dc67f137236ed39.zip
Eliminate some duplicate code
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
-rw-r--r--lib/umberlog.c17
1 files changed, 5 insertions, 12 deletions
diff --git a/lib/umberlog.c b/lib/umberlog.c
index 91f4cb4..2247464 100644
--- a/lib/umberlog.c
+++ b/lib/umberlog.c
@@ -276,14 +276,10 @@ _ul_json_vappend (ul_buffer_t *buffer, va_list ap)
return NULL;
buffer = ul_buffer_append (buffer, key, value);
+ free (value);
if (buffer == NULL)
- {
- free (value);
- return NULL;
- }
-
- free (value);
+ return NULL;
_ul_va_spin (fmt, ap);
}
@@ -366,14 +362,11 @@ _ul_vformat (ul_buffer_t *buffer, int format_version,
return NULL;
buffer = ul_buffer_append (buffer, "msg", value);
- if (buffer == NULL)
- {
- free (value);
- return NULL;
- }
-
free (value);
+ if (buffer == NULL)
+ return NULL;
+
_ul_va_spin (msg_format, ap);
if (format_version > 0)