summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorJohan Hovold <jhovold@gmail.com>2010-05-15 17:53:43 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2010-07-05 11:15:39 -0700
commit780018f66c645dc98991c543bb4d6cc1133b1a06 (patch)
treed9c2c9ed0ba155ea89d7708c8b03b8deb404f551 /drivers
parentb1c2d6c2234a04895db0bbd4b50a16453b6c4567 (diff)
downloadkernel-crypto-780018f66c645dc98991c543bb4d6cc1133b1a06.tar.gz
kernel-crypto-780018f66c645dc98991c543bb4d6cc1133b1a06.tar.xz
kernel-crypto-780018f66c645dc98991c543bb4d6cc1133b1a06.zip
USB: kobil: fix memory leak
commit c0f631d1948658b27349545b2cbcb4b32f010c7a upstream. An urb transfer buffer is allocated at every open but was never freed. This driver is a bit of a mess... Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/serial/kobil_sct.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index 45ea694b3ae..9d99e682f96 100644
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -345,7 +345,8 @@ static void kobil_close(struct usb_serial_port *port)
/* FIXME: Add rts/dtr methods */
if (port->write_urb) {
- usb_kill_urb(port->write_urb);
+ usb_poison_urb(port->write_urb);
+ kfree(port->write_urb->transfer_buffer);
usb_free_urb(port->write_urb);
port->write_urb = NULL;
}