summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorInaky Perez-Gonzalez <inaky@linux.intel.com>2009-05-08 08:58:51 -0700
committerInaky Perez-Gonzalez <inaky@linux.intel.com>2009-06-11 03:30:18 -0700
commitfff1068559a2ae00a036b80c5df3c564fc6c6305 (patch)
treebe56841153c1bb258e7d535a9c84a851336c4ffa /drivers/net
parentfb10167478a3a8e29fe122a7bf4c67b5cfc48a1b (diff)
downloadkernel-crypto-fff1068559a2ae00a036b80c5df3c564fc6c6305.tar.gz
kernel-crypto-fff1068559a2ae00a036b80c5df3c564fc6c6305.tar.xz
kernel-crypto-fff1068559a2ae00a036b80c5df3c564fc6c6305.zip
wimax/i2400m: don't call netif_start_queue() in _tx_msg_sent()
Reported and fixed by Cindy H Kao. When the device is stopped __i2400m_dev_stop() stops the network queue. However, when this is done in the middle of heavy network operation, when the bus-specific subdriver is still wrapping up and it reports a sent TX transaction with _tx_msg_sent() right after the device was stopped, the queue was being started again, which was causing a stream of oopsen and finally a panic. In any case, said call has no place there. It's a left over from an early implementation that was discarded later on. Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/wimax/i2400m/tx.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/wimax/i2400m/tx.c b/drivers/net/wimax/i2400m/tx.c
index 613a88ffd65..8ef724d31fb 100644
--- a/drivers/net/wimax/i2400m/tx.c
+++ b/drivers/net/wimax/i2400m/tx.c
@@ -773,7 +773,6 @@ void i2400m_tx_msg_sent(struct i2400m *i2400m)
n = i2400m->tx_out / I2400M_TX_BUF_SIZE;
i2400m->tx_out %= I2400M_TX_BUF_SIZE;
i2400m->tx_in -= n * I2400M_TX_BUF_SIZE;
- netif_start_queue(i2400m->wimax_dev.net_dev);
spin_unlock_irqrestore(&i2400m->tx_lock, flags);
d_fnend(3, dev, "(i2400m %p) = void\n", i2400m);
}