[FIX] Fixed some things that Krazy complained about

git-svn-id: https://pokegen.svn.sourceforge.net/svnroot/pokegen/trunk@266 6ecfd1a5-f3ed-3746-8530-beee90d26b22

7 files changed, 22 insertions, 12 deletions

diff --git a/Changelog b/Changelog
index 699f092f..64f629b6 100644
--- a/Changelog
+++ b/Changelog
@@ -1,4 +1,11 @@
 -----------------
+Rev:  266
+Date: 23 September 2008
+User: MathStuf
+-----------------
+[FIX] Fixed some things that Krazy complained about
+
+-----------------
 Rev:  265
 Date: 16 September 2008
 User: MathStuf
diff --git a/sigbattle/TurnArena.cpp b/sigbattle/TurnArena.cpp
index 6016d3d8..bd176677 100644
--- a/sigbattle/TurnArena.cpp
+++ b/sigbattle/TurnArena.cpp
@@ -97,7 +97,7 @@ void Sigbattle::TurnArena::processRound()
         }
     }
     qStableSort(actions.begin(), actions.end(), sortActions);
-    foreach (TeamMember::RequestedAction action, actions)
+    foreach (const TeamMember::RequestedAction& action, actions)
     {
         if (action.first->currentHp())
             handleAction(action.first, action.second);
diff --git a/sigen.spec b/sigen.spec
index b7cd9925..de78ffe7 100644
--- a/sigen.spec
+++ b/sigen.spec
@@ -1,6 +1,6 @@
 Name:           sigen
 Version:        0.0.2
-Release:        0.19.20080907svn262%{?dist}
+Release:        0.20.20080923svn266%{?dist}
 Summary:        An RPG/Strategy engine inspired by the Pokémon™ games
 
 Group:          Amusements/Games
@@ -8,7 +8,7 @@ License:        GPLv3+
 URL:            http://www.sourceforge.net/projects/sigen
 # The source for this package was pulled from upstream's vcs.  Use the
 # following commands to generate the tarball:
-#  svn export -r 262 http://sigen.svn.sourceforge.net/svnroot/sigen/trunk sigen-0.0.2
+#  svn export -r 266 http://sigen.svn.sourceforge.net/svnroot/sigen/trunk sigen-0.0.2
 #  tar -c sigen-0.0.2 | bzip2 --best -c > sigen-0.0.2.tar.bz2
 Source0:        %{name}-%{version}.tar.bz2
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
@@ -143,6 +143,9 @@ update-mime-database %{_datadir}/mime &> /dev/null || :
 
 
 %changelog
+* Tue Sep 23 2008 Ben Boeckel <MathStuf@gmail.com> 0.0.2-0.20.20080923svn266
+- Newer SVN
+
 * Sat Sep 13 2008 Ben Boeckel <MathStuf@gmail.com> 0.0.2-0.19.20080907svn262
 - Newer SVN
 
diff --git a/sigmodr/ScriptWidget.cpp b/sigmodr/ScriptWidget.cpp
index b7110536..d3df997c 100644
--- a/sigmodr/ScriptWidget.cpp
+++ b/sigmodr/ScriptWidget.cpp
@@ -48,7 +48,7 @@ Sigmodr::ScriptWidget::ScriptWidget(QWidget* parent, const Sigmod::Script& value
     languages["Python"] = "python";
     languages["Ruby"] = "ruby";
     QList<QString> langs = languages.keys();
-    foreach (QString language, langs)
+    foreach (const QString& language, langs)
         varInterpreter->addItem(language, languages[language]);
     if (!m_editor)
     {
diff --git a/sigmodr/SigmodTree.cpp b/sigmodr/SigmodTree.cpp
index 5cae7d47..cdcb548b 100644
--- a/sigmodr/SigmodTree.cpp
+++ b/sigmodr/SigmodTree.cpp
@@ -108,7 +108,7 @@ void Sigmodr::SigmodTree::deleteSigmod(const Sigmod::Sigmod* sigmod)
 
 bool Sigmodr::SigmodTree::isOpen(const KUrl& url) const
 {
-    foreach (UrlDirty pair, m_sigmods.values())
+    foreach (const UrlDirty& pair, m_sigmods.values())
     {
         if (url == pair.first)
             return true;
@@ -126,7 +126,7 @@ KUrl Sigmodr::SigmodTree::url(const Sigmod::Sigmod* sigmod) const
 QStringList Sigmodr::SigmodTree::urls() const
 {
     QStringList urls;
-    foreach (UrlDirty pair, m_sigmods.values())
+    foreach (const UrlDirty& pair, m_sigmods.values())
         urls << pair.first.prettyUrl();
     return urls;
 }
diff --git a/sigmodr/SigmodTreeModel.cpp b/sigmodr/SigmodTreeModel.cpp
index f1d9b4a3..cc5d3179 100644
--- a/sigmodr/SigmodTreeModel.cpp
+++ b/sigmodr/SigmodTreeModel.cpp
@@ -157,7 +157,7 @@ bool Sigmodr::SigmodTreeModel::dropMimeData(const QMimeData* data, Qt::DropActio
     else if (data->hasFormat("text/uri-list"))
     {
         QList<QUrl> urls = data->urls();
-        foreach (QUrl url, urls)
+        foreach (const QUrl& url, urls)
         {
             emit(layoutAboutToBeChanged());
             success = parent.isValid() ? setData(parent, url.toEncoded(), Sigmodr::BaseModel::XmlRole) : m_root->setData(url.toEncoded(), Sigmodr::BaseModel::XmlRole);
diff --git a/sigmodr/SigmodrUI.cpp b/sigmodr/SigmodrUI.cpp
index 17b6ce13..20a24fd8 100644
--- a/sigmodr/SigmodrUI.cpp
+++ b/sigmodr/SigmodrUI.cpp
@@ -77,7 +77,7 @@ Sigmodr::SigmodrUI::SigmodrUI(QWidget* parent) :
     else if (m_config.readEntry("reloadOnStart", false))
     {
         QStringList urls = m_config.readEntry("Opened Files", QStringList());
-        foreach (QString url, urls)
+        foreach (const QString& url, urls)
             openSigmod(KUrl(url));
     }
     setAutoSaveSettings("MainWindow", true);
@@ -125,7 +125,7 @@ void Sigmodr::SigmodrUI::newSigmod()
 void Sigmodr::SigmodrUI::openSigmod()
 {
     KUrl::List urls = KFileDialog::getOpenUrls(KUrl("kfiledialog:///sigmod"), "*.smod|Sigmod files", this);
-    foreach (KUrl url, urls)
+    foreach (const KUrl& url, urls)
     {
         if (!url.isEmpty())
             openSigmod(url);
@@ -291,7 +291,7 @@ void Sigmodr::SigmodrUI::uploadSigmod(const Sigmod::Sigmod* sigmod)
     if (engine.init("sigmod.knsrc"))
     {
         if (!engine.uploadDialogModal(url.path()))
-            KMessageBox::error(this, "An error occured attempting to upload!", "Upload error");
+            KMessageBox::error(this, "An error occurred attempting to upload!", "Upload error");
     }
 }
 
@@ -416,7 +416,7 @@ void Sigmodr::SigmodrUI::on_treeSigmod_customContextMenuRequested(const QPoint&
     if (menu)
     {
         QString type = treeSigmod->model()->data(index, BaseModel::TypeRole).toString();
-        QStringList types = treeSigmod->model()->data(index, BaseModel::DropAcceptRole).toString().split(";");
+        QStringList types = treeSigmod->model()->data(index, BaseModel::DropAcceptRole).toString().split(';');
         KAction* paste = new KAction("&Paste", this);
         connect(paste, SIGNAL(triggered()), this, SLOT(pasteObject()));
         paste->setEnabled(types.contains(m_clipboard.doctype().name()));
@@ -462,7 +462,7 @@ void Sigmodr::SigmodrUI::dropEvent(QDropEvent* event)
     else if (data->hasFormat("text/uri-list"))
     {
         QList<QUrl> urls = data->urls();
-        foreach (QUrl url, urls)
+        foreach (const QUrl& url, urls)
             loaded = openSigmod(url);
     }
     if (loaded)