summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPavel Reichl <preichl@redhat.com>2015-09-04 07:02:42 -0400
committerJakub Hrozek <jhrozek@redhat.com>2015-10-02 12:50:26 +0200
commit12440d2acbeb7ea6e5c0e4182d00377c8d01185b (patch)
treee84e37385b9ea3a8d30b02edb221a22790dcd490
parent6735c0451d4e80d7cd4b480a8c1f7dafb2b536ea (diff)
downloadsssd-12440d2acbeb7ea6e5c0e4182d00377c8d01185b.tar.gz
sssd-12440d2acbeb7ea6e5c0e4182d00377c8d01185b.tar.xz
sssd-12440d2acbeb7ea6e5c0e4182d00377c8d01185b.zip
AD: fix minor memory leak
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
-rw-r--r--src/providers/ad/ad_common.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/providers/ad/ad_common.c b/src/providers/ad/ad_common.c
index 130cdeb61..88f36f8ea 100644
--- a/src/providers/ad/ad_common.c
+++ b/src/providers/ad/ad_common.c
@@ -745,7 +745,7 @@ ad_failover_init(TALLOC_CTX *mem_ctx, struct be_ctx *bectx,
ret = be_add_online_cb(bectx, bectx, ad_online_cb, service, NULL);
if (ret != EOK) {
DEBUG(SSSDBG_CRIT_FAILURE, "Could not set up AD online callback\n");
- return ret;
+ goto done;
}
ret = be_fo_service_add_callback(mem_ctx, bectx, ad_service,
@@ -797,7 +797,8 @@ ad_resolve_callback(void *private_data, struct fo_server *server)
sdata = fo_get_server_user_data(server);
if (fo_is_srv_lookup(server) == false && sdata == NULL) {
DEBUG(SSSDBG_CRIT_FAILURE, "No user data?\n");
- return;
+ ret = EINVAL;
+ goto done;
}
service = talloc_get_type(private_data, struct ad_service);