summaryrefslogtreecommitdiffstats
path: root/array.c
diff options
context:
space:
mode:
authormatz <matz@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2008-04-14 03:58:35 +0000
committermatz <matz@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2008-04-14 03:58:35 +0000
commit38deb17a19a015b5b3b4d5a74762391ba3b6f256 (patch)
treea7d38d5822f0bfde2395c427011ccd1a37258a29 /array.c
parent806b8ecb7d6932991cb4c70e6474a97e733d63a2 (diff)
downloadruby-38deb17a19a015b5b3b4d5a74762391ba3b6f256.tar.gz
ruby-38deb17a19a015b5b3b4d5a74762391ba3b6f256.tar.xz
ruby-38deb17a19a015b5b3b4d5a74762391ba3b6f256.zip
* array.c (ary_new): new integer overflow check condition.
suggested by TOYOFUKU Chikanobu <nobu_toyofuku at nifty.com> in [ruby-dev:34156]. * array.c (rb_ary_initialize): ditto. git-svn-id: http://svn.ruby-lang.org/repos/ruby/trunk@15997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'array.c')
-rw-r--r--array.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/array.c b/array.c
index 8ccbd97ff..edbc35d4b 100644
--- a/array.c
+++ b/array.c
@@ -114,7 +114,7 @@ ary_new(VALUE klass, long len)
if (len < 0) {
rb_raise(rb_eArgError, "negative array size (or size too big)");
}
- if (len > 0 && len * (long)sizeof(VALUE) <= len) {
+ if (len > LONG_MAX / sizeof(VALUE)) {
rb_raise(rb_eArgError, "array size too big");
}
ary = ary_alloc(klass);
@@ -313,7 +313,7 @@ rb_ary_initialize(int argc, VALUE *argv, VALUE ary)
if (len < 0) {
rb_raise(rb_eArgError, "negative array size");
}
- if (len > 0 && len * (long)sizeof(VALUE) <= len) {
+ if (len > LONG_MAX / sizeof(VALUE)) {
rb_raise(rb_eArgError, "array size too big");
}
rb_ary_modify(ary);