| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
Also rename env_vars -> env-vars (for uniformity).
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
Also reflect the changes in the tests.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
|
| |
Former is preferred, per:
<http://www.linux-ha.org/doc/dev-guides/_actions.html>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
In very rough state for now.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
|
|
| |
... as they were actually meant like that from the beginning (it's true
that Pacemaker can mimic some of these also with primitive resources,
but we are looking at the conversion perspective now).
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
... per what's actually implemented.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
(fix tabs/spaces issue along the way)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
|
|
| |
Previously, the fact that --transform applies also to the symlink
content was missed and resulted in an archive that wasn't directly
usable. Also drop maintenance-specific "vim local rc" file.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
For this monitor operation, either use the interval as designated in the
original rgmanager agent (sticking with the most basic=lowest depth only),
or use the default of 60 seconds (the same is automatically injected as
a default by pcs).
Resolves: <https://bugzilla.redhat.com/1272570>.
Also adjust the (unit) tests respectively.
Reported-by: Miroslav Lisik <mlisik@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
Adapt that in the test as well.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
This should prevent run_check_cmd getting stale.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Previous one was just splitting into lines within a single group
(also, this was limited to at most one split! that in turn made
it a pretty broken text wrapping). Now it is two-ways allowing
also short-enough groups to be put on the same line, and as many
line splits is made as necessary for a proper text wrapping.
Also update the test counterparts (function run_check_cmd of
run-check script succeeds again after quite a long time!).
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
|
|
|
|
| |
It is in /corosync/totem/@cluster_name for corosync.conf XML
representation, not at the location expected in cluster.conf
(/cluster/@name).
Also fix the (still failing) ccs2pcscmd test run in run-check.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
(this one was affecting Travis CI runs)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hasn't been considered before (hence the bug being fixed), and
it seems best if --dist in "global options" (prior to cmd spec) is the
only to influence command alias resolution, whereas --dist as "command
option" can influence some specifics for the command itself.
This way, natural causality on the command line is preserved.
Alternatively, we could look-ahead if there is dist defined as command
option and considered it in the alias resolution. But rather than
that, it would more bearable to remove --dist/--sys from command options
altogether but that would prevent injecting them when command-by-symlink
is exercised, so do not do this either.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...found by static analysis
Account for simplistic logic of the call site (our goal is not
"read as many bytes as you can, stop on first allocation error,
but be fine with what was read so far, if any" -- that is not
intended when you need to read whole parseable XML).
There are more considerations:
- realloc(p, 0) may or may not free p, one shouldn't free it manually
to prevent double-free (do I understand "man 3p realloc" right?)
- length (size_t) can overflow, leading realloc to actually decrease
the allocated memory, perhaps even to zero, i.e., possible free
as mentioned above)
- realloc(NULL, size) == malloc(size)
- check in "if (x) free(x);" is redundant
- if read_pipe returns OK, we can now safely assume: size > 0
Also following principles are followed:
- there should be just one cleanup on error
- notable code branches and otherwise silent assumptions commented upon
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
See <https://bugzilla.redhat.com/show_bug.cgi?id=593721>.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
Cf. SAP{Database,Instance}.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
Open source infrastructure FTW!
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
|
|
|
| |
Apparently, rule is supposed to accompany the actual nvpair that will be
applied in case such condition holds (otherwise it's a no-op).
Adjust a check script respectively.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
| |
|
|
|
|
| |
(merge build- and run-time deps)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|