diff options
author | Lukas Slebodnik <lslebodn@redhat.com> | 2014-09-15 16:05:30 +0200 |
---|---|---|
committer | Jakub Hrozek <jhrozek@redhat.com> | 2015-02-11 20:38:42 +0100 |
commit | 5085d263f2f084778b1314fc5e808668c3758d82 (patch) | |
tree | da7a12dd45222166481c225963bfedca23aaa115 /src/providers/proxy | |
parent | 5594736ea2618bb3e487f47fd199e1d2cf4c58fd (diff) | |
download | sssd-5085d263f2f084778b1314fc5e808668c3758d82.tar.gz sssd-5085d263f2f084778b1314fc5e808668c3758d82.tar.xz sssd-5085d263f2f084778b1314fc5e808668c3758d82.zip |
Fix warning: equality comparison with extraneous parentheses
Example of warning:
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]
if (((wbc_status) == WBC_ERR_SUCCESS)) {
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
note: remove extraneous parentheses around the comparison
to silence this warning
if (((wbc_status) == WBC_ERR_SUCCESS)) {
~ ^ ~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
note: use '=' to turn this equality comparison into an assignment
if (((wbc_status) == WBC_ERR_SUCCESS)) {
^~
=
The reason is definition of some macros which were used in if conditions.
Reviewed-by: Michal Židek <mzidek@redhat.com>
Diffstat (limited to 'src/providers/proxy')
-rw-r--r-- | src/providers/proxy/proxy_auth.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/providers/proxy/proxy_auth.c b/src/providers/proxy/proxy_auth.c index a901f0f17..d85320cf6 100644 --- a/src/providers/proxy/proxy_auth.c +++ b/src/providers/proxy/proxy_auth.c @@ -365,7 +365,7 @@ static void pc_init_sig_handler(struct tevent_context *ev, "child [%d] was stopped by signal [%d].\n", ret, WSTOPSIG(child_status)); } - if (WIFCONTINUED(child_status)) { + if (WIFCONTINUED(child_status) == true) { DEBUG(SSSDBG_CRIT_FAILURE, "child [%d] was resumed by delivery of SIGCONT.\n", ret); @@ -522,7 +522,7 @@ static void proxy_child_sig_handler(struct tevent_context *ev, DEBUG(SSSDBG_CONF_SETTINGS, "child [%d] exited with status [%d].\n", ret, WEXITSTATUS(child_status)); - } else if (WIFSIGNALED(child_status)) { + } else if (WIFSIGNALED(child_status) == true) { DEBUG(SSSDBG_CONF_SETTINGS, "child [%d] was terminated by signal [%d].\n", ret, WTERMSIG(child_status)); @@ -532,7 +532,7 @@ static void proxy_child_sig_handler(struct tevent_context *ev, "child [%d] was stopped by signal [%d].\n", ret, WSTOPSIG(child_status)); } - if (WIFCONTINUED(child_status)) { + if (WIFCONTINUED(child_status) == true) { DEBUG(SSSDBG_CRIT_FAILURE, "child [%d] was resumed by delivery of SIGCONT.\n", ret); |