summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOndrej Kos <okos@redhat.com>2013-05-24 13:48:42 +0200
committerJakub Hrozek <jhrozek@redhat.com>2013-05-27 19:20:26 +0200
commitbfdb2eeed95bde6cd065a9a47a7cb1773990ccfb (patch)
tree7290db581e81c34be0ba75e97e4313606af76f5b
parentc89e13316166957c853ed61496a17306e59afc79 (diff)
downloadsssd-bfdb2eeed95bde6cd065a9a47a7cb1773990ccfb.tar.gz
sssd-bfdb2eeed95bde6cd065a9a47a7cb1773990ccfb.tar.xz
sssd-bfdb2eeed95bde6cd065a9a47a7cb1773990ccfb.zip
Fail with misconfigured id-mapping ranges
https://fedorahosted.org/sssd/ticket/1930 On misconfigured id-mapping range variables, the provider should not start. We were internally correctly setting error code for failure, but interruption of startup was not performed. Also raised the debug level of message for this misconfiguration.
-rw-r--r--src/providers/ldap/sdap_idmap.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/providers/ldap/sdap_idmap.c b/src/providers/ldap/sdap_idmap.c
index 43db0c833..a81bc98b8 100644
--- a/src/providers/ldap/sdap_idmap.c
+++ b/src/providers/ldap/sdap_idmap.c
@@ -81,10 +81,11 @@ sdap_idmap_init(TALLOC_CTX *mem_ctx,
|| idmap_upper <= idmap_lower
|| (idmap_upper-idmap_lower) < rangesize)
{
- DEBUG(SSSDBG_CRIT_FAILURE,
+ DEBUG(SSSDBG_FATAL_FAILURE,
("Invalid settings for range selection: [%d][%d][%d]\n",
idmap_lower, idmap_upper, rangesize));
ret = EINVAL;
+ goto done;
}
if (((idmap_upper - idmap_lower) % rangesize) != 0) {