From bfdb2eeed95bde6cd065a9a47a7cb1773990ccfb Mon Sep 17 00:00:00 2001 From: Ondrej Kos Date: Fri, 24 May 2013 13:48:42 +0200 Subject: Fail with misconfigured id-mapping ranges https://fedorahosted.org/sssd/ticket/1930 On misconfigured id-mapping range variables, the provider should not start. We were internally correctly setting error code for failure, but interruption of startup was not performed. Also raised the debug level of message for this misconfiguration. --- src/providers/ldap/sdap_idmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/providers/ldap/sdap_idmap.c b/src/providers/ldap/sdap_idmap.c index 43db0c833..a81bc98b8 100644 --- a/src/providers/ldap/sdap_idmap.c +++ b/src/providers/ldap/sdap_idmap.c @@ -81,10 +81,11 @@ sdap_idmap_init(TALLOC_CTX *mem_ctx, || idmap_upper <= idmap_lower || (idmap_upper-idmap_lower) < rangesize) { - DEBUG(SSSDBG_CRIT_FAILURE, + DEBUG(SSSDBG_FATAL_FAILURE, ("Invalid settings for range selection: [%d][%d][%d]\n", idmap_lower, idmap_upper, rangesize)); ret = EINVAL; + goto done; } if (((idmap_upper - idmap_lower) % rangesize) != 0) { -- cgit