diff options
| author | Pierre-Yves Chibon <pingou@pingoured.fr> | 2015-07-28 11:19:49 +0000 |
|---|---|---|
| committer | Patrick Uiterwijk <puiterwijk@redhat.com> | 2015-08-11 12:08:50 +0200 |
| commit | ce2bbec3f2a010cfa26363a91a6224efe484f06f (patch) | |
| tree | 0195f3654105f7a1e6b72743322c024c4717718b /ipsilon/install/ipsilon-server-install | |
| parent | db9da225bce11ddeef1b5a2d511f18e17a808f15 (diff) | |
| download | ipsilon-ce2bbec3f2a010cfa26363a91a6224efe484f06f.tar.gz ipsilon-ce2bbec3f2a010cfa26363a91a6224efe484f06f.tar.xz ipsilon-ce2bbec3f2a010cfa26363a91a6224efe484f06f.zip | |
Drop all the calls to .keys() when iterating on the keys of a dict
When browsing the keys of a dictionary, you can use the ``.keys()`` method but
that is in fact only really useful if you want to store the list of keys first
and act on them (like sorting them or so).
If you just want to iterate through all the keys, no matter the order, then it
is much much faster to just do: ``for key in dict``
Some stats about this can be found there:
http://blog.pingoured.fr/index.php?post/2012/03/12/Python-notes-to-self
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
Reviewed-by: Simo Sorce <simo@redhat.com>
Diffstat (limited to 'ipsilon/install/ipsilon-server-install')
| -rwxr-xr-x | ipsilon/install/ipsilon-server-install | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ipsilon/install/ipsilon-server-install b/ipsilon/install/ipsilon-server-install index 6c7c6dd..80bd274 100755 --- a/ipsilon/install/ipsilon-server-install +++ b/ipsilon/install/ipsilon-server-install @@ -313,7 +313,7 @@ def parse_config_profile(args): if g in globals(): globals()[g] = val else: - for k in globals().keys(): + for k in globals(): if k.lower() == g.lower(): globals()[k] = val break |