Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Missed to properly merge patch for definition of MAX_MISSING_LEN | Zdenek Kabelac | 2012-02-28 | 1 | -1/+1 | |
| | | | | (fix previous commit) | |||||
* | Add log_sys_error for close | Zdenek Kabelac | 2012-02-28 | 2 | -18/+19 | |
| | ||||||
* | Limit max size of clvmd message | Zdenek Kabelac | 2012-02-28 | 1 | -1/+3 | |
| | | | | | | | | | | This could be seen as some sort of simple validation - it's not easy to recognize a valid message for now - but we definitely do not want to allocate a lot of megabytes in clvmd memory locked daemon when broken message gets in. Size of 8000 is just selected for now - possibly there could be much lower value put in. | |||||
* | Do not send uninitilised bytes | Zdenek Kabelac | 2012-02-28 | 1 | -31/+27 | |
| | | | | | Use struct initalizers to fill struct members and at the same time have all unspecified members set to 0. | |||||
* | Do not hide deallocation of buffer | Zdenek Kabelac | 2012-02-27 | 1 | -2/+2 | |
| | | | | | | | | As API is passing structures by value, do not leave the function which created buffer and keeps valid pointer look like it would be some memory leak and move free of buffer from inner function - makes more obvious, how is the memory management handled. | |||||
* | Add FIXME for misuse in case of dm_event_mask enum. | Zdenek Kabelac | 2012-02-27 | 2 | -0/+4 | |
| | | | | Using enum for bitmask is not proper solution here. | |||||
* | Add some log_sys_errors to close() call | Zdenek Kabelac | 2012-02-27 | 1 | -1/+2 | |
| | ||||||
* | Nicer cleanup of excl_uuid hash | Zdenek Kabelac | 2012-02-27 | 1 | -3/+7 | |
| | | | | | Since it on exit path, it's not a big difference, but makes less noise in analyzer and valgrind. | |||||
* | Systemd is linux-specific - move the supporting code under the 'ifdef linux'. | Peter Rajnoha | 2012-02-27 | 1 | -70/+74 | |
| | | | | | Some 'defines' used in this specific code were already under an ifdef so this patch just completes it. | |||||
* | Add assert for oldname | Zdenek Kabelac | 2012-02-27 | 1 | -0/+1 | |
| | | | | | | | Code cannot proceed if oldname would be NULL. Since lvmetad currently doesn't use logging mechanism of lvm to report internal errors - stay with current code style of lvmetad which uses plain asserts for cases like this. | |||||
* | A bit more safe version of sprintf | Zdenek Kabelac | 2012-02-27 | 1 | -1/+1 | |
| | | | | Use just buffer size limit (it's used for debug only) | |||||
* | Move allocation after check for vgid | Zdenek Kabelac | 2012-02-27 | 1 | -1/+4 | |
| | | | | | so there is no mem leak on this error path. Also actually check if the hash exists. | |||||
* | Explicitely ignore result from sync_unlock() | Zdenek Kabelac | 2012-02-27 | 1 | -1/+1 | |
| | | | | Make it obvious to analyzer - we can't do anything better here anyway. | |||||
* | Drop uname call, it's not used from gulm era. | Zdenek Kabelac | 2012-02-27 | 1 | -2/+0 | |
| | ||||||
* | Improve error handling & reporting in common daemon code. | Petr Rockai | 2012-02-26 | 3 | -12/+15 | |
| | ||||||
* | Fix server-side leaks in lvmetad. | Petr Rockai | 2012-02-24 | 1 | -2/+8 | |
| | ||||||
* | Clean up the lvmetad state more thoroughly upon shutdown. | Petr Rockai | 2012-02-24 | 1 | -0/+8 | |
| | ||||||
* | Fix an error path in daemon_open. | Petr Rockai | 2012-02-24 | 1 | -1/+2 | |
| | ||||||
* | Couple of improvements in the daemon (common + lvmetad) code: | Petr Rockai | 2012-02-23 | 6 | -4/+56 | |
| | | | | | - some client-side memory leak fixes - announce and check protocols and protocol versions | |||||
* | Limit sscanf params with size | Zdenek Kabelac | 2012-02-23 | 1 | -2/+2 | |
| | | | | Make sure parsed string fits given char buffer. | |||||
* | Remaing code suffling | Zdenek Kabelac | 2012-02-23 | 1 | -8/+10 | |
| | | | | Move declaration to the front of function to follow coding rules. | |||||
* | Some reformating for lvmetad uddates | Zdenek Kabelac | 2012-02-23 | 2 | -51/+58 | |
| | | | | | | | cleanup gcc warning, use PRIu64 header cleanups const pointer fixes. | |||||
* | Add a missed dependency that is required to pull in dameons/common in an early | Petr Rockai | 2012-02-23 | 1 | -0/+1 | |
| | | | | part of the build. | |||||
* | We need daemons/common now even if the lvmetad server side is not built. | Petr Rockai | 2012-02-23 | 1 | -1/+3 | |
| | ||||||
* | The lvmetad client-side integration. Only active when use_lvmetad = 1 is set in | Petr Rockai | 2012-02-23 | 4 | -5/+4 | |
| | | | | lvm.conf *and* lvmetad is running. | |||||
* | Also use DEFAULT_RUN_DIR for the lvmetad socket on the client side. | Petr Rockai | 2012-02-23 | 1 | -1/+1 | |
| | ||||||
* | Tweak lvmetad a bit more: | Petr Rockai | 2012-02-21 | 1 | -17/+40 | |
| | | | | | | - allow at most one PV on any given device - allow PV lookup by device - merge the pvmeta info into VG metadata when responding to vg_lookup | |||||
* | Drop the now-redundant pvid_to_status hash. | Petr Rockai | 2012-02-15 | 1 | -35/+27 | |
| | ||||||
* | Update lvmetad: use device major/minor pair to track devices. Keep a pvmeta | Petr Rockai | 2012-02-15 | 1 | -79/+118 | |
| | | | | | | config tree per PV which is mostly provided by the client, so it can be used to keep track of things like label_sector, PV format, mda count / offsets and so on. | |||||
* | (lvmetad) Remove unused variable. | Petr Rockai | 2012-02-15 | 1 | -1/+1 | |
| | ||||||
* | In lvmetad, also nuke VGs when all their PVs are stolen by another VG (vgmerge | Petr Rockai | 2012-02-15 | 1 | -8/+28 | |
| | | | | & vgsplit do this). | |||||
* | Detect failing fifo | Zdenek Kabelac | 2012-02-15 | 1 | -0/+8 | |
| | | | | | If the fifo died because of dmeventd restart - do not wait for 20s in select - it will not get better and return error immediately. | |||||
* | lvmetad server-side update: | Petr Rockai | 2012-02-15 | 1 | -108/+410 | |
| | | | | | | | | - rename the hashes to be explicit about the mapping - add VG/PV listing calls to the protocol - cache slightly more of the per-PV state - filter cached metadata - compare the metadata upon metadata_update | |||||
* | Do not forget to initialise the error value in daemon_reply. | Petr Rockai | 2012-02-15 | 1 | -1/+1 | |
| | ||||||
* | Add some FIXME around allocation code | Zdenek Kabelac | 2012-02-13 | 1 | -8/+15 | |
| | | | | Remove also unreachable break.. | |||||
* | Make sure dereferenced words[0] and words[1] are defined | Zdenek Kabelac | 2012-02-13 | 1 | -1/+2 | |
| | ||||||
* | Check for missing reply_uuid | Zdenek Kabelac | 2012-02-13 | 1 | -0/+4 | |
| | ||||||
* | Check for allocation failure | Zdenek Kabelac | 2012-02-13 | 1 | -2/+9 | |
| | ||||||
* | Fix message check | Zdenek Kabelac | 2012-02-10 | 1 | -3/+3 | |
| | | | | | Check pointer from strchr for NULL instead of crash later. Badly formated message would have crash dmeventd otherwise. | |||||
* | Remove unreachable code | Zdenek Kabelac | 2012-02-10 | 1 | -1/+0 | |
| | ||||||
* | A bit more readable code | Zdenek Kabelac | 2012-02-08 | 1 | -16/+9 | |
| | | | | Just a minor readability conversion. | |||||
* | Remove unneeded assignments | Zdenek Kabelac | 2012-02-08 | 2 | -4/+2 | |
| | | | | Variables have (or will have) those values set. | |||||
* | Keep page_size as signed number | Zdenek Kabelac | 2012-02-08 | 1 | -1/+1 | |
| | | | | Since it's return value from sysconf and is checked for <0. | |||||
* | Add boundary test for number of mirror devs and logs | Zdenek Kabelac | 2012-02-08 | 1 | -2/+5 | |
| | | | | | | | As atoi may return negative value - test for both limits. Test log_args for limits before calling alloca(). Code from dmeventd mirror plugin should probably share same code as we have in mirrored.c. | |||||
* | Remove a dubious log message ("another thread is handling an event") from LVM | Petr Rockai | 2012-02-01 | 1 | -4/+1 | |
| | | | | dmeventd plugins. Fixes RHBZ 771419. | |||||
* | Automatically detect whether corosync clvmd needs to use confdb or cmap. (fabio) | Alasdair Kergon | 2012-01-31 | 2 | -4/+64 | |
| | ||||||
* | Oops missed braces in previous commit | Zdenek Kabelac | 2012-01-26 | 1 | -1/+2 | |
| | | | | | This has disabled clvmd for being executed. (FIXME improve testing part to catch this fault) | |||||
* | Fix leak of hash table | Zdenek Kabelac | 2012-01-25 | 1 | -0/+1 | |
| | | | | Minor leak on command initialization. | |||||
* | Set to a defined value vars used after error path | Zdenek Kabelac | 2012-01-25 | 1 | -1/+1 | |
| | | | | | Static analyzer noticed this vars are used even when error is reported back thus their state is undefined - set to 0 for this case. | |||||
* | Test for uname result | Zdenek Kabelac | 2012-01-25 | 1 | -1/+3 | |
| | | | | in fail path initialize to 0. |