diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2012-02-27 11:46:25 +0000 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2012-02-27 11:46:25 +0000 |
| commit | c57a9960b522e5f82eabfa29b1cb0ae7c00b1249 (patch) | |
| tree | ee1d3037f7f378c99402903aa91a959f79a00daf /daemons | |
| parent | f380cd7d9867fe00340ccfb61f642c0745d2b7a1 (diff) | |
| download | lvm2-c57a9960b522e5f82eabfa29b1cb0ae7c00b1249.tar.gz lvm2-c57a9960b522e5f82eabfa29b1cb0ae7c00b1249.tar.xz lvm2-c57a9960b522e5f82eabfa29b1cb0ae7c00b1249.zip | |
Add FIXME for misuse in case of dm_event_mask enum.
Using enum for bitmask is not proper solution here.
Diffstat (limited to 'daemons')
| -rw-r--r-- | daemons/dmeventd/dmeventd.h | 1 | ||||
| -rw-r--r-- | daemons/dmeventd/libdevmapper-event.h | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/daemons/dmeventd/dmeventd.h b/daemons/dmeventd/dmeventd.h index c60d402c..81056e90 100644 --- a/daemons/dmeventd/dmeventd.h +++ b/daemons/dmeventd/dmeventd.h @@ -63,6 +63,7 @@ struct dm_event_fifos { #define EXIT_CHDIR_FAILURE 7 /* Implemented in libdevmapper-event.c, but not part of public API. */ +// FIXME misuse of bitmask as enum int daemon_talk(struct dm_event_fifos *fifos, struct dm_event_daemon_message *msg, int cmd, const char *dso_name, const char *dev_name, diff --git a/daemons/dmeventd/libdevmapper-event.h b/daemons/dmeventd/libdevmapper-event.h index e07eaf6f..7ce3f397 100644 --- a/daemons/dmeventd/libdevmapper-event.h +++ b/daemons/dmeventd/libdevmapper-event.h @@ -82,6 +82,7 @@ void dm_event_handler_set_timeout(struct dm_event_handler *dmevh, int timeout); /* * Specify mask for events to monitor. */ +// FIXME misuse of bitmask as enum void dm_event_handler_set_event_mask(struct dm_event_handler *dmevh, enum dm_event_mask evmask); @@ -91,6 +92,7 @@ const char *dm_event_handler_get_uuid(const struct dm_event_handler *dmevh); int dm_event_handler_get_major(const struct dm_event_handler *dmevh); int dm_event_handler_get_minor(const struct dm_event_handler *dmevh); int dm_event_handler_get_timeout(const struct dm_event_handler *dmevh); +// FIXME misuse of bitmask as enum enum dm_event_mask dm_event_handler_get_event_mask(const struct dm_event_handler *dmevh); /* FIXME Review interface (what about this next thing?) */ @@ -104,6 +106,7 @@ int dm_event_unregister_handler(const struct dm_event_handler *dmevh); /* Prototypes for DSO interface, see dmeventd.c, struct dso_data for detailed descriptions. */ +// FIXME misuse of bitmask as enum void process_event(struct dm_task *dmt, enum dm_event_mask evmask, void **user); int register_device(const char *device_name, const char *uuid, int major, int minor, void **user); int unregister_device(const char *device_name, const char *uuid, int major, |