summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorAlasdair Kergon <agk@redhat.com>2010-12-08 20:50:48 +0000
committerAlasdair Kergon <agk@redhat.com>2010-12-08 20:50:48 +0000
commit2b82bd79f59ffb49cc864cf0d2e9268c652443d3 (patch)
tree597817553c3ff5b4d6072e7ee37508b6deafe830 /tools
parente8bed35ddf264c67c44b9cf9cedef6b078bfd710 (diff)
downloadlvm2-2b82bd79f59ffb49cc864cf0d2e9268c652443d3.tar.gz
lvm2-2b82bd79f59ffb49cc864cf0d2e9268c652443d3.tar.xz
lvm2-2b82bd79f59ffb49cc864cf0d2e9268c652443d3.zip
Rename vg_release to free_vg.
Diffstat (limited to 'tools')
-rw-r--r--tools/lvconvert.c10
-rw-r--r--tools/lvcreate.c4
-rw-r--r--tools/lvrename.c4
-rw-r--r--tools/lvresize.c4
-rw-r--r--tools/polldaemon.c8
-rw-r--r--tools/pvchange.c8
-rw-r--r--tools/pvcreate.c2
-rw-r--r--tools/pvdisplay.c4
-rw-r--r--tools/pvmove.c4
-rw-r--r--tools/pvresize.c4
-rw-r--r--tools/reporter.c8
-rw-r--r--tools/toollib.c22
-rw-r--r--tools/vgcreate.c6
-rw-r--r--tools/vgextend.c6
-rw-r--r--tools/vgmerge.c14
-rw-r--r--tools/vgreduce.c6
-rw-r--r--tools/vgrename.c10
-rw-r--r--tools/vgsplit.c22
18 files changed, 73 insertions, 73 deletions
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index 95b60cc6..7c7826bb 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -1619,7 +1619,7 @@ static struct logical_volume *get_vg_lock_and_logical_volume(struct cmd_context
{
/*
* Returns NULL if the requested LV doesn't exist;
- * otherwise the caller must vg_release(lv->vg)
+ * otherwise the caller must free_vg(lv->vg)
* - it is also up to the caller to unlock_vg() as needed
*/
struct volume_group *vg;
@@ -1627,13 +1627,13 @@ static struct logical_volume *get_vg_lock_and_logical_volume(struct cmd_context
vg = _get_lvconvert_vg(cmd, vg_name, NULL);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
return_NULL;
}
if (!(lv = _get_lvconvert_lv(cmd, vg, lv_name, NULL, 0))) {
log_error("Can't find LV %s in VG %s", lv_name, vg_name);
- unlock_and_release_vg(cmd, vg, vg_name);
+ unlock_and_free_vg(cmd, vg, vg_name);
return NULL;
}
@@ -1686,7 +1686,7 @@ bad:
ret = poll_logical_volume(cmd, lp->lv_to_poll,
lp->wait_completion);
- vg_release(lv->vg);
+ free_vg(lv->vg);
out:
init_ignore_suspended_devices(saved_ignore_suspended_devices);
return ret;
@@ -1736,7 +1736,7 @@ static int lvconvert_merge_single(struct cmd_context *cmd, struct logical_volume
}
}
- vg_release(refreshed_lv->vg);
+ free_vg(refreshed_lv->vg);
return ret;
}
diff --git a/tools/lvcreate.c b/tools/lvcreate.c
index dec786b8..13b59265 100644
--- a/tools/lvcreate.c
+++ b/tools/lvcreate.c
@@ -546,7 +546,7 @@ int lvcreate(struct cmd_context *cmd, int argc, char **argv)
log_verbose("Finding volume group \"%s\"", lp.vg_name);
vg = vg_read_for_update(cmd, lp.vg_name, NULL, 0);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
stack;
return ECMD_FAILED;
}
@@ -561,6 +561,6 @@ int lvcreate(struct cmd_context *cmd, int argc, char **argv)
r = ECMD_FAILED;
}
out:
- unlock_and_release_vg(cmd, vg, lp.vg_name);
+ unlock_and_free_vg(cmd, vg, lp.vg_name);
return r;
}
diff --git a/tools/lvrename.c b/tools/lvrename.c
index 2342ad0e..db47a8bc 100644
--- a/tools/lvrename.c
+++ b/tools/lvrename.c
@@ -104,7 +104,7 @@ int lvrename(struct cmd_context *cmd, int argc, char **argv)
log_verbose("Checking for existing volume group \"%s\"", vg_name);
vg = vg_read_for_update(cmd, vg_name, NULL, 0);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
stack;
return ECMD_FAILED;
}
@@ -123,6 +123,6 @@ int lvrename(struct cmd_context *cmd, int argc, char **argv)
r = ECMD_PROCESSED;
error:
- unlock_and_release_vg(cmd, vg, vg_name);
+ unlock_and_free_vg(cmd, vg, vg_name);
return r;
}
diff --git a/tools/lvresize.c b/tools/lvresize.c
index 9ce73b77..c970f3f5 100644
--- a/tools/lvresize.c
+++ b/tools/lvresize.c
@@ -738,7 +738,7 @@ int lvresize(struct cmd_context *cmd, int argc, char **argv)
log_verbose("Finding volume group %s", lp.vg_name);
vg = vg_read_for_update(cmd, lp.vg_name, NULL, 0);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
stack;
return ECMD_FAILED;
}
@@ -746,7 +746,7 @@ int lvresize(struct cmd_context *cmd, int argc, char **argv)
if (!(r = _lvresize(cmd, vg, &lp)))
stack;
- unlock_and_release_vg(cmd, vg, lp.vg_name);
+ unlock_and_free_vg(cmd, vg, lp.vg_name);
return r;
}
diff --git a/tools/polldaemon.c b/tools/polldaemon.c
index 8372ef25..50579bab 100644
--- a/tools/polldaemon.c
+++ b/tools/polldaemon.c
@@ -183,7 +183,7 @@ static int _wait_for_single_lv(struct cmd_context *cmd, const char *name, const
/* Locks the (possibly renamed) VG again */
vg = parms->poll_fns->get_copy_vg(cmd, name, uuid);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
log_error("ABORTING: Can't reread VG for %s", name);
/* What more could we do here? */
return 0;
@@ -193,16 +193,16 @@ static int _wait_for_single_lv(struct cmd_context *cmd, const char *name, const
parms->lv_type))) {
log_error("ABORTING: Can't find LV in %s for %s",
vg->name, name);
- unlock_and_release_vg(cmd, vg, vg->name);
+ unlock_and_free_vg(cmd, vg, vg->name);
return 0;
}
if (!_check_lv_status(cmd, vg, lv, name, parms, &finished)) {
- unlock_and_release_vg(cmd, vg, vg->name);
+ unlock_and_free_vg(cmd, vg, vg->name);
return 0;
}
- unlock_and_release_vg(cmd, vg, vg->name);
+ unlock_and_free_vg(cmd, vg, vg->name);
/*
* FIXME Sleeping after testing, while preferred, also works around
diff --git a/tools/pvchange.c b/tools/pvchange.c
index 02d35105..28e71b84 100644
--- a/tools/pvchange.c
+++ b/tools/pvchange.c
@@ -240,7 +240,7 @@ int pvchange(struct cmd_context *cmd, int argc, char **argv)
}
vg = vg_read_for_update(cmd, vg_name, NULL, 0);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
stack;
continue;
}
@@ -254,7 +254,7 @@ int pvchange(struct cmd_context *cmd, int argc, char **argv)
total++;
done += _pvchange_single(cmd, vg,
pvl->pv, NULL);
- unlock_and_release_vg(cmd, vg, vg_name);
+ unlock_and_free_vg(cmd, vg, vg_name);
}
} else {
log_verbose("Scanning for physical volume names");
@@ -275,7 +275,7 @@ int pvchange(struct cmd_context *cmd, int argc, char **argv)
dm_list_iterate_items(sll, vgnames) {
vg = vg_read_for_update(cmd, sll->str, NULL, 0);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
stack;
continue;
}
@@ -285,7 +285,7 @@ int pvchange(struct cmd_context *cmd, int argc, char **argv)
pvl->pv,
NULL);
}
- unlock_and_release_vg(cmd, vg, sll->str);
+ unlock_and_free_vg(cmd, vg, sll->str);
}
}
}
diff --git a/tools/pvcreate.c b/tools/pvcreate.c
index 3dc3a3bd..a955d373 100644
--- a/tools/pvcreate.c
+++ b/tools/pvcreate.c
@@ -74,7 +74,7 @@ static int pvcreate_restore_params_validate(struct cmd_context *cmd,
pp->pe_start = pv_pe_start(existing_pvl->pv);
pp->extent_size = pv_pe_size(existing_pvl->pv);
pp->extent_count = pv_pe_count(existing_pvl->pv);
- vg_release(vg);
+ free_vg(vg);
}
if (arg_sign_value(cmd, physicalvolumesize_ARG, 0) == SIGN_MINUS) {
diff --git a/tools/pvdisplay.c b/tools/pvdisplay.c
index 47def172..1ae0339a 100644
--- a/tools/pvdisplay.c
+++ b/tools/pvdisplay.c
@@ -32,7 +32,7 @@ static int _pvdisplay_single(struct cmd_context *cmd,
vg = vg_read(cmd, vg_name, (char *)&pv->vgid, 0);
if (vg_read_error(vg)) {
log_error("Skipping volume group %s", vg_name);
- vg_release(vg);
+ free_vg(vg);
/* FIXME If CLUSTERED should return ECMD_PROCESSED here */
return ECMD_FAILED;
}
@@ -85,7 +85,7 @@ out:
if (vg_name)
unlock_vg(cmd, vg_name);
if (!old_vg)
- vg_release(vg);
+ free_vg(vg);
return ret;
}
diff --git a/tools/pvmove.c b/tools/pvmove.c
index ce48c68e..51f442fa 100644
--- a/tools/pvmove.c
+++ b/tools/pvmove.c
@@ -445,7 +445,7 @@ static int _set_up_pvmove(struct cmd_context *cmd, const char *pv_name,
vg = _get_vg(cmd, pv_vg_name(pv));
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
stack;
return ECMD_FAILED;
}
@@ -510,7 +510,7 @@ static int _set_up_pvmove(struct cmd_context *cmd, const char *pv_name,
/* LVs are all in status LOCKED */
r = ECMD_PROCESSED;
out:
- unlock_and_release_vg(cmd, vg, pv_vg_name(pv));
+ unlock_and_free_vg(cmd, vg, pv_vg_name(pv));
return r;
}
diff --git a/tools/pvresize.c b/tools/pvresize.c
index af499e5b..8582ef42 100644
--- a/tools/pvresize.c
+++ b/tools/pvresize.c
@@ -58,7 +58,7 @@ static int _pv_resize_single(struct cmd_context *cmd,
vg = vg_read_for_update(cmd, vg_name, NULL, 0);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
log_error("Unable to read volume group \"%s\".",
vg_name);
return 0;
@@ -164,7 +164,7 @@ static int _pv_resize_single(struct cmd_context *cmd,
out:
unlock_vg(cmd, vg_name);
if (!old_vg)
- vg_release(vg);
+ free_vg(vg);
return r;
}
diff --git a/tools/reporter.c b/tools/reporter.c
index 40d3c9aa..fbd0c274 100644
--- a/tools/reporter.c
+++ b/tools/reporter.c
@@ -65,7 +65,7 @@ static int _pvsegs_sub_single(struct cmd_context *cmd,
};
if (!(_free_vg.vgmem = dm_pool_create("_free_vg", 10240)))
- return ECMD_FAILED;
+ return ECMD_FAILED;
struct logical_volume _free_logical_volume = {
.vg = vg ?: &_free_vg,
@@ -110,7 +110,7 @@ static int _pvsegs_sub_single(struct cmd_context *cmd,
goto_out;
}
out:
- dm_pool_destroy(_free_vg.vgmem);
+ free_vg(&_free_vg);
return ret;
}
@@ -145,7 +145,7 @@ static int _pvs_single(struct cmd_context *cmd, struct volume_group *vg,
vg = vg_read(cmd, vg_name, (char *)&pv->vgid, 0);
if (vg_read_error(vg)) {
log_error("Skipping volume group %s", vg_name);
- vg_release(vg);
+ free_vg(vg);
return ECMD_FAILED;
}
@@ -185,7 +185,7 @@ out:
unlock_vg(cmd, vg_name);
if (!old_vg)
- vg_release(vg);
+ free_vg(vg);
return ret;
}
diff --git a/tools/toollib.c b/tools/toollib.c
index 9be99362..0a1a8d48 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -311,7 +311,7 @@ int process_each_lv(struct cmd_context *cmd, int argc, char **argv,
}
if (!cmd_vg_read(cmd, &cmd_vgs)) {
- cmd_vg_release(&cmd_vgs);
+ free_cmd_vgs(&cmd_vgs);
if (ret_max < ECMD_FAILED) {
log_error("Skipping volume group %s", vgname);
ret_max = ECMD_FAILED;
@@ -337,7 +337,7 @@ int process_each_lv(struct cmd_context *cmd, int argc, char **argv,
dm_pool_strdup(cmd->mem,
lv_name + 1))) {
log_error("strlist allocation failed");
- cmd_vg_release(&cmd_vgs);
+ free_cmd_vgs(&cmd_vgs);
return ECMD_FAILED;
}
}
@@ -355,7 +355,7 @@ int process_each_lv(struct cmd_context *cmd, int argc, char **argv,
dm_list_init(&lvnames);
dm_list_splice(&lvnames, &failed_lvnames);
- cmd_vg_release(&cmd_vgs);
+ free_cmd_vgs(&cmd_vgs);
if (!cmd_vg_read(cmd, &cmd_vgs)) {
ret = ECMD_FAILED; /* break */
break;
@@ -364,7 +364,7 @@ int process_each_lv(struct cmd_context *cmd, int argc, char **argv,
if (ret > ret_max)
ret_max = ret;
- cmd_vg_release(&cmd_vgs);
+ free_cmd_vgs(&cmd_vgs);
/* FIXME: logic for breaking command is not consistent */
if (sigint_caught())
return ECMD_FAILED;
@@ -392,7 +392,7 @@ int process_each_segment_in_pv(struct cmd_context *cmd,
vg = vg_read(cmd, vg_name, NULL, 0);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
log_error("Skipping volume group %s", vg_name);
return ECMD_FAILED;
}
@@ -404,7 +404,7 @@ int process_each_segment_in_pv(struct cmd_context *cmd,
if (!(pvl = find_pv_in_vg(vg, pv_dev_name(pv)))) {
log_error("Unable to find %s in volume group %s",
pv_dev_name(pv), vg_name);
- unlock_and_release_vg(cmd, vg, vg_name);
+ unlock_and_free_vg(cmd, vg, vg_name);
return ECMD_FAILED;
}
@@ -427,7 +427,7 @@ int process_each_segment_in_pv(struct cmd_context *cmd,
if (vg_name)
unlock_vg(cmd, vg_name);
if (!old_vg)
- vg_release(vg);
+ free_vg(vg);
return ret_max;
}
@@ -498,10 +498,10 @@ static int _process_one_vg(struct cmd_context *cmd, const char *vg_name,
if (!cvl_vg->vg->cmd_missing_vgs)
break;
- cmd_vg_release(&cmd_vgs);
+ free_cmd_vgs(&cmd_vgs);
}
- cmd_vg_release(&cmd_vgs);
+ free_cmd_vgs(&cmd_vgs);
return (ret > ret_max) ? ret : ret_max;
}
@@ -774,7 +774,7 @@ int process_each_pv(struct cmd_context *cmd, int argc, char **argv,
vg = vg_read(cmd, sll->str, NULL, flags);
if (vg_read_error(vg)) {
ret_max = ECMD_FAILED;
- vg_release(vg);
+ free_vg(vg);
stack;
continue;
}
@@ -783,7 +783,7 @@ int process_each_pv(struct cmd_context *cmd, int argc, char **argv,
handle,
process_single_pv);
- unlock_and_release_vg(cmd, vg, sll->str);
+ unlock_and_free_vg(cmd, vg, sll->str);
if (ret > ret_max)
ret_max = ret;
diff --git a/tools/vgcreate.c b/tools/vgcreate.c
index 3c4c6d2d..49574f33 100644
--- a/tools/vgcreate.c
+++ b/tools/vgcreate.c
@@ -56,7 +56,7 @@ int vgcreate(struct cmd_context *cmd, int argc, char **argv)
log_error("A volume group called %s already exists.", vp_new.vg_name);
else
log_error("Can't get lock for %s.", vp_new.vg_name);
- vg_release(vg);
+ free_vg(vg);
return ECMD_FAILED;
}
@@ -120,13 +120,13 @@ int vgcreate(struct cmd_context *cmd, int argc, char **argv)
log_print("%s%colume group \"%s\" successfully created",
clustered_message, *clustered_message ? 'v' : 'V', vg->name);
- vg_release(vg);
+ free_vg(vg);
return ECMD_PROCESSED;
bad:
unlock_vg(cmd, VG_ORPHANS);
bad_orphan:
- vg_release(vg);
+ free_vg(vg);
unlock_vg(cmd, vp_new.vg_name);
return ECMD_FAILED;
}
diff --git a/tools/vgextend.c b/tools/vgextend.c
index f91b1d3f..a0c166b0 100644
--- a/tools/vgextend.c
+++ b/tools/vgextend.c
@@ -72,7 +72,7 @@ int vgextend(struct cmd_context *cmd, int argc, char **argv)
log_verbose("Checking for volume group \"%s\"", vg_name);
vg = vg_read_for_update(cmd, vg_name, NULL, 0);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
stack;
return ECMD_FAILED;
}
@@ -92,7 +92,7 @@ int vgextend(struct cmd_context *cmd, int argc, char **argv)
} else { /* no --restore, normal vgextend */
if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
log_error("Can't get lock for orphan PVs");
- unlock_and_release_vg(cmd, vg, vg_name);
+ unlock_and_free_vg(cmd, vg, vg_name);
return ECMD_FAILED;
}
@@ -135,6 +135,6 @@ int vgextend(struct cmd_context *cmd, int argc, char **argv)
bad:
if (!arg_count(cmd, restoremissing_ARG))
unlock_vg(cmd, VG_ORPHANS);
- unlock_and_release_vg(cmd, vg, vg_name);
+ unlock_and_free_vg(cmd, vg, vg_name);
return r;
}
diff --git a/tools/vgmerge.c b/tools/vgmerge.c
index 403a5e04..4d55510e 100644
--- a/tools/vgmerge.c
+++ b/tools/vgmerge.c
@@ -22,7 +22,7 @@ static struct volume_group *_vgmerge_vg_read(struct cmd_context *cmd,
log_verbose("Checking for volume group \"%s\"", vg_name);
vg = vg_read_for_update(cmd, vg_name, NULL, 0);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
return NULL;
}
return vg;
@@ -54,7 +54,7 @@ static int _vgmerge_single(struct cmd_context *cmd, const char *vg_name_to,
vg_to = _vgmerge_vg_read(cmd, vg_name_to);
if (!vg_to) {
stack;
- unlock_and_release_vg(cmd, vg_from, vg_name_from);
+ unlock_and_free_vg(cmd, vg_from, vg_name_from);
return ECMD_FAILED;
}
} else {
@@ -67,7 +67,7 @@ static int _vgmerge_single(struct cmd_context *cmd, const char *vg_name_to,
vg_from = _vgmerge_vg_read(cmd, vg_name_from);
if (!vg_from) {
stack;
- unlock_and_release_vg(cmd, vg_to, vg_name_to);
+ unlock_and_free_vg(cmd, vg_to, vg_name_to);
return ECMD_FAILED;
}
}
@@ -148,11 +148,11 @@ static int _vgmerge_single(struct cmd_context *cmd, const char *vg_name_to,
r = ECMD_PROCESSED;
bad:
if (lock_vg_from_first) {
- unlock_and_release_vg(cmd, vg_to, vg_name_to);
- unlock_and_release_vg(cmd, vg_from, vg_name_from);
+ unlock_and_free_vg(cmd, vg_to, vg_name_to);
+ unlock_and_free_vg(cmd, vg_from, vg_name_from);
} else {
- unlock_and_release_vg(cmd, vg_from, vg_name_from);
- unlock_and_release_vg(cmd, vg_to, vg_name_to);
+ unlock_and_free_vg(cmd, vg_from, vg_name_from);
+ unlock_and_free_vg(cmd, vg_to, vg_name_to);
}
return r;
}
diff --git a/tools/vgreduce.c b/tools/vgreduce.c
index eceafcd5..4aa8f01e 100644
--- a/tools/vgreduce.c
+++ b/tools/vgreduce.c
@@ -450,7 +450,7 @@ static int _vgreduce_single(struct cmd_context *cmd, struct volume_group *vg,
log_print("Removed \"%s\" from volume group \"%s\"", name, vg->name);
r = ECMD_PROCESSED;
bad:
- unlock_and_release_vg(cmd, orphan_vg, VG_ORPHANS);
+ unlock_and_free_vg(cmd, orphan_vg, VG_ORPHANS);
return r;
}
@@ -524,7 +524,7 @@ int vgreduce(struct cmd_context *cmd, int argc, char **argv)
goto out;
}
- vg_release(vg);
+ free_vg(vg);
log_verbose("Trying to open VG %s for recovery...", vg_name);
vg = vg_read_for_update(cmd, vg_name, NULL,
@@ -570,7 +570,7 @@ int vgreduce(struct cmd_context *cmd, int argc, char **argv)
}
out:
init_ignore_suspended_devices(saved_ignore_suspended_devices);
- unlock_and_release_vg(cmd, vg, vg_name);
+ unlock_and_free_vg(cmd, vg, vg_name);
return ret;
diff --git a/tools/vgrename.c b/tools/vgrename.c
index 3c383fbd..98be9a96 100644
--- a/tools/vgrename.c
+++ b/tools/vgrename.c
@@ -25,7 +25,7 @@ static struct volume_group *_get_old_vg_for_rename(struct cmd_context *cmd,
nevertheless. */
vg = vg_read_for_update(cmd, vg_name_old, vgid, READ_ALLOW_EXPORTED);
if (vg_read_error(vg)) {
- vg_release(vg);
+ free_vg(vg);
return_NULL;
}
@@ -117,7 +117,7 @@ static int vg_rename_path(struct cmd_context *cmd, const char *old_vg_path,
return_0;
if (!_lock_new_vg_for_rename(cmd, vg_name_new)) {
- unlock_and_release_vg(cmd, vg, vg_name_old);
+ unlock_and_free_vg(cmd, vg, vg_name_old);
return_0;
}
} else {
@@ -168,7 +168,7 @@ static int vg_rename_path(struct cmd_context *cmd, const char *old_vg_path,
backup_remove(cmd, vg_name_old);
unlock_vg(cmd, vg_name_new);
- unlock_and_release_vg(cmd, vg, vg_name_old);
+ unlock_and_free_vg(cmd, vg, vg_name_old);
log_print("Volume group \"%s\" successfully renamed to \"%s\"",
vg_name_old, vg_name_new);
@@ -182,9 +182,9 @@ static int vg_rename_path(struct cmd_context *cmd, const char *old_vg_path,
error:
if (lock_vg_old_first) {
unlock_vg(cmd, vg_name_new);
- unlock_and_release_vg(cmd, vg, vg_name_old);
+ unlock_and_free_vg(cmd, vg, vg_name_old);
} else {
- unlock_and_release_vg(cmd, vg, vg_name_old);
+ unlock_and_free_vg(cmd, vg, vg_name_old);
unlock_vg(cmd, vg_name_new);
}
return 0;
diff --git a/tools/vgsplit.c b/tools/vgsplit.c
index e6a65111..045c699f 100644
--- a/tools/vgsplit.c
+++ b/tools/vgsplit.c
@@ -223,16 +223,16 @@ static struct volume_group *_vgsplit_to(struct cmd_context *cmd,
vg_to = vg_create(cmd, vg_name_to);
if (vg_read_error(vg_to) == FAILED_LOCKING) {
log_error("Can't get lock for %s", vg_name_to);
- vg_release(vg_to);
+ free_vg(vg_to);
return NULL;
}
if (vg_read_error(vg_to) == FAILED_EXIST) {
*existing_vg = 1;
- vg_release(vg_to);
+ free_vg(vg_to);
vg_to = vg_read_for_update(cmd, vg_name_to, NULL, 0);
if (vg_read_error(vg_to)) {
- vg_release(vg_to);
+ free_vg(vg_to);
stack;
return NULL;
}
@@ -258,7 +258,7 @@ static struct volume_group *_vgsplit_from(struct cmd_context *cmd,
vg_from = vg_read_for_update(cmd, vg_name_from, NULL, 0);
if (vg_read_error(vg_from)) {
- vg_release(vg_from);
+ free_vg(vg_from);
return NULL;
}
return vg_from;
@@ -333,7 +333,7 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv)
vg_to = _vgsplit_to(cmd, vg_name_to, &existing_vg);
if (!vg_to) {
- unlock_and_release_vg(cmd, vg_from, vg_name_from);
+ unlock_and_free_vg(cmd, vg_from, vg_name_from);
stack;
return ECMD_FAILED;
}
@@ -345,7 +345,7 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv)
}
vg_from = _vgsplit_from(cmd, vg_name_from);
if (!vg_from) {
- unlock_and_release_vg(cmd, vg_to, vg_name_to);
+ unlock_and_free_vg(cmd, vg_to, vg_name_to);
stack;
return ECMD_FAILED;
}
@@ -462,7 +462,7 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv)
* Finally, remove the EXPORTED flag from the new VG and write it out.
*/
if (!test_mode()) {
- vg_release(vg_to);
+ free_vg(vg_to);
vg_to = vg_read_for_update(cmd, vg_name_to, NULL,
READ_ALLOW_EXPORTED);
if (vg_read_error(vg_to)) {
@@ -487,11 +487,11 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv)
bad:
if (lock_vg_from_first) {
- unlock_and_release_vg(cmd, vg_to, vg_name_to);
- unlock_and_release_vg(cmd, vg_from, vg_name_from);
+ unlock_and_free_vg(cmd, vg_to, vg_name_to);
+ unlock_and_free_vg(cmd, vg_from, vg_name_from);
} else {
- unlock_and_release_vg(cmd, vg_from, vg_name_from);
- unlock_and_release_vg(cmd, vg_to, vg_name_to);
+ unlock_and_free_vg(cmd, vg_from, vg_name_from);
+ unlock_and_free_vg(cmd, vg_to, vg_name_to);
}
return r;
}