summaryrefslogtreecommitdiffstats
path: root/tools/vgcreate.c
diff options
context:
space:
mode:
authorMilan Broz <mbroz@redhat.com>2009-12-28 18:34:45 +0000
committerMilan Broz <mbroz@redhat.com>2009-12-28 18:34:45 +0000
commiteb751255394ba3baf710d069a3b3e205c94d4224 (patch)
treef038a3edab323a62e5c9a61d48b9a7f6de961124 /tools/vgcreate.c
parent0c409a58ee313e65b6423b29f075e3dc8452f20c (diff)
downloadlvm2-eb751255394ba3baf710d069a3b3e205c94d4224.tar.gz
lvm2-eb751255394ba3baf710d069a3b3e205c94d4224.tar.xz
lvm2-eb751255394ba3baf710d069a3b3e205c94d4224.zip
Fix previous vgcreate commit to not call unpaired unlock.
Diffstat (limited to 'tools/vgcreate.c')
-rw-r--r--tools/vgcreate.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/vgcreate.c b/tools/vgcreate.c
index bcae2a2e..5113b1f5 100644
--- a/tools/vgcreate.c
+++ b/tools/vgcreate.c
@@ -60,7 +60,8 @@ int vgcreate(struct cmd_context *cmd, int argc, char **argv)
log_error("A volume group called %s already exists.", vp_new.vg_name);
else
log_error("Can't get lock for %s.", vp_new.vg_name);
- goto bad;
+ vg_release(vg);
+ return ECMD_FAILED;
}
if (!vg_set_extent_size(vg, vp_new.extent_size) ||
@@ -68,7 +69,7 @@ int vgcreate(struct cmd_context *cmd, int argc, char **argv)
!vg_set_max_pv(vg, vp_new.max_pv) ||
!vg_set_alloc_policy(vg, vp_new.alloc) ||
!vg_set_clustered(vg, vp_new.clustered))
- goto_bad;
+ goto bad_orphan;
if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
log_error("Can't get lock for orphan PVs");