summaryrefslogtreecommitdiffstats
path: root/tools/lvcreate.c
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2011-11-10 12:40:29 +0000
committerZdenek Kabelac <zkabelac@redhat.com>2011-11-10 12:40:29 +0000
commita538e369db166e2b2bc4ef752e5c59a0b888f83e (patch)
treeb727aadabaef90078fdf0601349f600df2eae114 /tools/lvcreate.c
parent95308c5f58f37d75dab3bd9eb15a90d1e90eeda2 (diff)
downloadlvm2-a538e369db166e2b2bc4ef752e5c59a0b888f83e.tar.gz
lvm2-a538e369db166e2b2bc4ef752e5c59a0b888f83e.tar.xz
lvm2-a538e369db166e2b2bc4ef752e5c59a0b888f83e.zip
Thin move _read_activation_params check
Since we finaly recognize thin creation only after _determine_snapshot_type() - move _read_activation_params() after it - so we can support lvcreate -an thin snapshot.
Diffstat (limited to 'tools/lvcreate.c')
-rw-r--r--tools/lvcreate.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/tools/lvcreate.c b/tools/lvcreate.c
index 9d035b8c..9c6150ce 100644
--- a/tools/lvcreate.c
+++ b/tools/lvcreate.c
@@ -789,9 +789,6 @@ static int _lvcreate_params(struct lvcreate_params *lp,
return 0;
}
- if (!_read_activation_params(lp, cmd))
- return_0;
-
/*
* Allocation parameters
*/
@@ -993,6 +990,15 @@ int lvcreate(struct cmd_context *cmd, int argc, char **argv)
goto_out;
}
+ /*
+ * Check activation parameters to support inactive thin snapshot creation
+ * FIXME: anything else needs to be moved past _determine_snapshot_type()?
+ */
+ if (!_read_activation_params(&lp, cmd)) {
+ r = ECMD_FAILED;
+ goto_out;
+ }
+
if (!_update_extents_params(vg, &lp, &lcp)) {
r = ECMD_FAILED;
goto_out;