summaryrefslogtreecommitdiffstats
path: root/tools/lvconvert.c
diff options
context:
space:
mode:
authorJonathan Earl Brassow <jbrassow@redhat.com>2010-08-02 19:03:45 +0000
committerJonathan Earl Brassow <jbrassow@redhat.com>2010-08-02 19:03:45 +0000
commitefaaf3146da35481375b700d6cba6eb32435e275 (patch)
treecd2ae0f9689e87cb48a6cadc57334d01c50f71c1 /tools/lvconvert.c
parent0dfae7e47a7702d0f362ff7636628716325e96cd (diff)
downloadlvm2-efaaf3146da35481375b700d6cba6eb32435e275.tar.gz
lvm2-efaaf3146da35481375b700d6cba6eb32435e275.tar.xz
lvm2-efaaf3146da35481375b700d6cba6eb32435e275.zip
Disallow mirrored logs in cluster mirrors.
The cluster log daemon (cmirrord) is not multi-threaded and can handle only one request at a time. When a log is stacked on top of a mirror (which itself contains a 'core' log), it creates a situation that cannot be solved without threading. When the top level mirror issues a "resume", the log daemon attempts to read from the log device to retrieve the log state. However, the log is a mirror which, before issuing the read, attempts to determine the 'sync' status of the region of the mirror which is to be read. This sync status request cannot be completed by the daemon because it is blocked on a read I/O to the very mirror requesting the sync status.
Diffstat (limited to 'tools/lvconvert.c')
-rw-r--r--tools/lvconvert.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index 5dda2993..9f90468d 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -919,6 +919,15 @@ static int _lvconvert_mirrors_parse_params(struct cmd_context *cmd,
return 0;
}
+ /*
+ * No mirrored logs for cluster mirrors until
+ * log daemon is multi-threaded.
+ */
+ if ((*new_log_count == 2) && vg_is_clustered(lv->vg)) {
+ log_error("Log type, \"mirrored\", is unavailable to cluster mirrors");
+ return 0;
+ }
+
log_verbose("Setting logging type to %s", mirrorlog);
/*