diff options
author | Dave Wysochanski <dwysocha@redhat.com> | 2009-07-28 00:36:58 +0000 |
---|---|---|
committer | Dave Wysochanski <dwysocha@redhat.com> | 2009-07-28 00:36:58 +0000 |
commit | 42a871b3dfde42bd999c346f9cd8163460c1f73d (patch) | |
tree | d5334f5f1ce38e601663c16717874f5620f9cc81 /liblvm/.exported_symbols | |
parent | d4b311970dc9a8977951ba9cc34a8485456e9b62 (diff) | |
download | lvm2-42a871b3dfde42bd999c346f9cd8163460c1f73d.tar.gz lvm2-42a871b3dfde42bd999c346f9cd8163460c1f73d.tar.xz lvm2-42a871b3dfde42bd999c346f9cd8163460c1f73d.zip |
Update lvm.h to address feeback.
This addresses a a large amount of Alasdair's review. Subsequent patches
will address remaining issues.
Addressed:
// FIXME Mention that's also required on error.
// FIXME Be consistent in terminology. It's called "system_dir" then last sentence says "system directory setting". Is it referring to "system_dir" there or something else?
// FIXME Mention it frees all resources and cannot be used subsequently?
// FIXME What does "any system configuration" mean?
// FIXME Expand on that explanation a bit, now that we know what the other fns look like.
// FIXME Not sure about that - it needs to scan sometimes. "will not" or "might not" ?
// FIXME: That's a FIXME in the code!!!
// FIXME What does "copied" mean in this context???
// FIXME Say what struct the returned struct dm_list is a list of...
// FIXME "This API" ? This function creates an object in memory?
// FIXME This function commits the Volume Group object referenced by the VG handle to disk?
// FIXME Where is "Name" defined? Absolute pathname?
Outstanding:
// FIXME Version function first? No structs or handles needed for that.
// FIXME Sort out this alignment. "Set an" directly below "system_dir" looks awful. Indent differently? More blank lines?
// FIXME Check how doxygen processes this. E.g. "return: LVM handle. You must use lvm_error() to check there were no errors and confirm that the handle is valid for passing to other functions."
// FIXME Find a better name. lvm_init.
// FIXME Consider renaming according to the new name for lvm_create.
// FIXME Please can we use dm_malloc throughout?
Diffstat (limited to 'liblvm/.exported_symbols')
0 files changed, 0 insertions, 0 deletions