diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2012-02-08 12:57:15 +0000 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2012-02-08 12:57:15 +0000 |
| commit | 9278655de141a3021ae5e22fbb2a9ad44b5ab464 (patch) | |
| tree | d6b6477d634421f7a09e890787f7af6c345d3fab /lib | |
| parent | 462835faa0d1ee57f346f3cad4c4825e079e4e38 (diff) | |
| download | lvm2-9278655de141a3021ae5e22fbb2a9ad44b5ab464.tar.gz lvm2-9278655de141a3021ae5e22fbb2a9ad44b5ab464.tar.xz lvm2-9278655de141a3021ae5e22fbb2a9ad44b5ab464.zip | |
Some fixmes
'len' calculation is unused ?
Unreachable code could be removed or moved upward ?
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/cache/lvmcache.c | 1 | ||||
| -rw-r--r-- | lib/misc/lvm-string.c | 5 |
2 files changed, 4 insertions, 2 deletions
diff --git a/lib/cache/lvmcache.c b/lib/cache/lvmcache.c index 3d9c152e..a804d53a 100644 --- a/lib/cache/lvmcache.c +++ b/lib/cache/lvmcache.c @@ -987,6 +987,7 @@ static int _lvmcache_update_vgid(struct lvmcache_info *info, if (vginfo && *vginfo->vgid) dm_hash_remove(_vgid_hash, vginfo->vgid); if (!vgid) { + /* FIXME: unreachable code path */ log_debug("lvmcache: %s: clearing VGID", info ? dev_name(info->dev) : vginfo->vgname); return 1; } diff --git a/lib/misc/lvm-string.c b/lib/misc/lvm-string.c index 6932e235..7e4bbdd2 100644 --- a/lib/misc/lvm-string.c +++ b/lib/misc/lvm-string.c @@ -49,12 +49,13 @@ int emit_to_buffer(char **buffer, size_t *size, const char *fmt, ...) int validate_tag(const char *n) { register char c; - register int len = 0; + /* int len = 0; */ if (!n || !*n) return 0; - while ((len++, c = *n++)) + /* FIXME: Is unlimited tag size support needed ? */ + while ((/* len++, */ c = *n++)) if (!isalnum(c) && c != '.' && c != '_' && c != '-' && c != '+' && c != '/' && c != '=' && c != '!' && c != ':' && c != '&' && c != '#') return 0; |