diff options
| author | Dave Wysochanski <dwysocha@redhat.com> | 2007-07-12 04:12:04 +0000 |
|---|---|---|
| committer | Dave Wysochanski <dwysocha@redhat.com> | 2007-07-12 04:12:04 +0000 |
| commit | 30303765a3e70aec8352ad69e1a32bc6b2829b54 (patch) | |
| tree | a67a60846c1b5b47b79c3bdeafe1803026f8dd9b /lib | |
| parent | c25403967772fb20062837e8f58f60e5329493ba (diff) | |
| download | lvm2-30303765a3e70aec8352ad69e1a32bc6b2829b54.tar.gz lvm2-30303765a3e70aec8352ad69e1a32bc6b2829b54.tar.xz lvm2-30303765a3e70aec8352ad69e1a32bc6b2829b54.zip | |
Refactor vg_extend error path.
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/metadata/metadata.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c index 7a58929d..c0499098 100644 --- a/lib/metadata/metadata.c +++ b/lib/metadata/metadata.c @@ -249,15 +249,17 @@ int vg_extend(struct volume_group *vg, int pv_count, char **pv_names) /* attach each pv */ for (i = 0; i < pv_count; i++) - if (!_add_pv_to_vg(vg, pv_names[i])) { - log_error("Unable to add physical volume '%s' to " - "volume group '%s'.", pv_names[i], vg->name); - return 0; - } + if (!_add_pv_to_vg(vg, pv_names[i])) + goto bad; /* FIXME Decide whether to initialise and add new mdahs to format instance */ return 1; + + bad: + log_error("Unable to add physical volume '%s' to " + "volume group '%s'.", pv_names[i], vg->name); + return 0; } const char *strip_dir(const char *vg_name, const char *dev_dir) |