diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2012-03-23 10:34:51 +0000 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2012-03-23 10:34:51 +0000 |
| commit | 2dba5632066ca05821567424d7b5d111a5c6eb11 (patch) | |
| tree | b7e5bac7842e424887e05f4e616115d408f56340 /daemons/lvmetad | |
| parent | 0fc9a3dce396f3d4e4f402d499ab8bb92342cd53 (diff) | |
| download | lvm2-2dba5632066ca05821567424d7b5d111a5c6eb11.tar.gz lvm2-2dba5632066ca05821567424d7b5d111a5c6eb11.tar.xz lvm2-2dba5632066ca05821567424d7b5d111a5c6eb11.zip | |
Add fixmes
There is missing some proper reaction when update fails ?
Diffstat (limited to 'daemons/lvmetad')
| -rw-r--r-- | daemons/lvmetad/lvmetad-core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/daemons/lvmetad/lvmetad-core.c b/daemons/lvmetad/lvmetad-core.c index a3811c2b..5b34e21a 100644 --- a/daemons/lvmetad/lvmetad-core.c +++ b/daemons/lvmetad/lvmetad-core.c @@ -675,6 +675,7 @@ static int remove_metadata(lvmetad_state *s, const char *vgid, int update_pvids) assert(oldname); if (update_pvids) + /* FIXME: What should happen when update fails */ update_pvid_to_vgid(s, old, "#orphan", 0); /* need to update what we have since we found a newer version */ dm_hash_remove(s->vgid_to_metadata, vgid); @@ -804,7 +805,8 @@ static int update_metadata(lvmetad_state *s, const char *name, const char *_vgid unlock_vgid_to_metadata(s); if (retval) - update_pvid_to_vgid(s, cft, vgid, 1); + /* FIXME: What should happen when update fails */ + retval = update_pvid_to_vgid(s, cft, vgid, 1); unlock_pvid_to_vgid(s); out: |