diff options
author | Milan Broz <mbroz@redhat.com> | 2011-03-01 20:17:56 +0000 |
---|---|---|
committer | Milan Broz <mbroz@redhat.com> | 2011-03-01 20:17:56 +0000 |
commit | cbedb99e4cece1bdd29381bfca4ee9f936c9a98e (patch) | |
tree | 2bd3b5110dfb6a0b41572e760bd806fd340fac94 /daemons/clvmd/clvmd.c | |
parent | 0cb777d6423d862a18c5653bf270a1a7345b8269 (diff) | |
download | lvm2-cbedb99e4cece1bdd29381bfca4ee9f936c9a98e.tar.gz lvm2-cbedb99e4cece1bdd29381bfca4ee9f936c9a98e.tar.xz lvm2-cbedb99e4cece1bdd29381bfca4ee9f936c9a98e.zip |
Fix some compile warnings on RHEL5
- returned char not needed to be explicitly const
- warn if pipe() fails in clvmd (more fixes here needed for error paths...)
- assign (and ignore) read() output in drain buffer
Diffstat (limited to 'daemons/clvmd/clvmd.c')
-rw-r--r-- | daemons/clvmd/clvmd.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/daemons/clvmd/clvmd.c b/daemons/clvmd/clvmd.c index d74a8805..00d330dc 100644 --- a/daemons/clvmd/clvmd.c +++ b/daemons/clvmd/clvmd.c @@ -1007,7 +1007,10 @@ static void be_daemon(int timeout) exit(3); } - pipe(child_pipe); + if (pipe(child_pipe)) { + perror("Error creating pipe"); + exit(3); + } switch (fork()) { case -1: @@ -1254,7 +1257,9 @@ static int read_from_local_sock(struct local_client *thisfd) } /* Create a pipe and add the reading end to our FD list */ - pipe(comms_pipe); + if (pipe(comms_pipe)) + DEBUGLOG("creating pipe failed: %s\n", strerror(errno)); + newfd = malloc(sizeof(struct local_client)); if (!newfd) { struct clvm_header reply; |