diff options
author | Zdenek Kabelac <zkabelac@redhat.com> | 2012-03-01 09:50:04 +0000 |
---|---|---|
committer | Zdenek Kabelac <zkabelac@redhat.com> | 2012-03-01 09:50:04 +0000 |
commit | ce1c28af1973457a9a661ce5c613bdec7761ae50 (patch) | |
tree | 5f4afc04246f920e717fe79106dc0a51c641e021 | |
parent | 2455ce226d312fcc9b038b146c697c09c24314a4 (diff) | |
download | lvm2-ce1c28af1973457a9a661ce5c613bdec7761ae50.tar.gz lvm2-ce1c28af1973457a9a661ce5c613bdec7761ae50.tar.xz lvm2-ce1c28af1973457a9a661ce5c613bdec7761ae50.zip |
Log fail of pthread_join
Syslog error outside of mutex section.
-rw-r--r-- | WHATS_NEW_DM | 1 | ||||
-rw-r--r-- | daemons/dmeventd/dmeventd.c | 6 |
2 files changed, 6 insertions, 1 deletions
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM index 49cc80e0..98f10199 100644 --- a/WHATS_NEW_DM +++ b/WHATS_NEW_DM @@ -1,5 +1,6 @@ Version 1.02.73 - ==================================== + Log failure of pthread_join when cleaning unused threads in dmeventd. Fix empty string warning logic in _find_config_str. (1.02.68) Fix dm_task_set_name to properly resolve path to dm name (1.02.71). Add dm_strncpy() function as a faster strncpy() replacement. diff --git a/daemons/dmeventd/dmeventd.c b/daemons/dmeventd/dmeventd.c index 6a674104..5c232644 100644 --- a/daemons/dmeventd/dmeventd.c +++ b/daemons/dmeventd/dmeventd.c @@ -1517,6 +1517,7 @@ static void _cleanup_unused_threads(void) int ret; struct dm_list *l; struct thread_status *thread; + int join_ret = 0; _lock_mutex(); while ((l = dm_list_first(&_thread_registry_unused))) { @@ -1556,12 +1557,15 @@ static void _cleanup_unused_threads(void) if (thread->status == DM_THREAD_DONE) { dm_list_del(l); - pthread_join(thread->thread, NULL); + join_ret = pthread_join(thread->thread, NULL); _free_thread_status(thread); } } _unlock_mutex(); + + if (join_ret) + syslog(LOG_ERR, "Failed pthread_join: %s\n", strerror(join_ret)); } static void _sig_alarm(int signum __attribute__((unused))) |