summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Rajnoha <prajnoha@redhat.com>2012-02-15 14:50:33 +0000
committerPeter Rajnoha <prajnoha@redhat.com>2012-02-15 14:50:33 +0000
commit9a0cf1ad8489967ee6752b6e79c97adbecc53609 (patch)
treee8701c207daf6f9dfe49358d8fb3b91556d21dff
parentea7b3d8fd7e2a3b68cb1f6c3c2fc6bc43eb10ac3 (diff)
downloadlvm2-9a0cf1ad8489967ee6752b6e79c97adbecc53609.tar.gz
lvm2-9a0cf1ad8489967ee6752b6e79c97adbecc53609.tar.xz
lvm2-9a0cf1ad8489967ee6752b6e79c97adbecc53609.zip
Add watch rule to 13-dm-disk.rules.
We don't have anything better yet... The problems the watch rule caused when removing devices should be covered now with the "retry remove" logic. It's also better to have this maintained by us, rather than having this rule anywhere else without proper control.
-rw-r--r--WHATS_NEW_DM1
-rw-r--r--udev/13-dm-disk.rules11
2 files changed, 12 insertions, 0 deletions
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index de270918..353e97bc 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,6 @@
Version 1.02.71 -
====================================
+ Add "watch" rule to 13-dm-disk.rules.
Detect failing fifo and skip 20s retry communication period.
Add DM_DEFAULT_NAME_MANGLING_MODE env. variable to override configured value.
Add dm_lib_init to automatically initialise device-mapper library on load.
diff --git a/udev/13-dm-disk.rules b/udev/13-dm-disk.rules
index 271ca227..9565ea71 100644
--- a/udev/13-dm-disk.rules
+++ b/udev/13-dm-disk.rules
@@ -24,4 +24,15 @@ ENV{DM_UDEV_LOW_PRIORITY_FLAG}=="1", OPTIONS="link_priority=-100"
ENV{ID_FS_USAGE}=="filesystem|other|crypto", ENV{ID_FS_UUID_ENC}=="?*", SYMLINK+="disk/by-uuid/$env{ID_FS_UUID_ENC}"
ENV{ID_FS_USAGE}=="filesystem|other", ENV{ID_FS_LABEL_ENC}=="?*", SYMLINK+="disk/by-label/$env{ID_FS_LABEL_ENC}"
+# Add inotify watch to track changes on this device.
+# Using the watch rule is not optimal - it generetes a lot of spurious
+# and useless events whenever the device opened for read-write is closed.
+# The best would be to generete the event directly in the tool changing
+# relevant information so only relevant events will be processed
+# (like creating a filesystem, changing filesystem label etc.).
+#
+# But let's use this until we have something better...
+
+OPTIONS+="watch"
+
LABEL="dm_end"