summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2011-09-25 19:45:40 +0000
committerZdenek Kabelac <zkabelac@redhat.com>2011-09-25 19:45:40 +0000
commit807a5a7b1333bf9fc857ec73c3ec0d827c1064f5 (patch)
treeacff586a399023d746c3e18448c07337df1f00a0
parentd2c25f02e8bc16c735ca846a66aedf042fa1de18 (diff)
downloadlvm2-807a5a7b1333bf9fc857ec73c3ec0d827c1064f5.tar.gz
lvm2-807a5a7b1333bf9fc857ec73c3ec0d827c1064f5.tar.xz
lvm2-807a5a7b1333bf9fc857ec73c3ec0d827c1064f5.zip
Remove test for NULL
Since it's internal function and we always check for NULL value before call - this is safe. Just for case add nonnull attribute so analyzer might better catch error.
-rw-r--r--libdm/libdm-config.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/libdm/libdm-config.c b/libdm/libdm-config.c
index 5280953b..a831936e 100644
--- a/libdm/libdm-config.c
+++ b/libdm/libdm-config.c
@@ -1225,14 +1225,12 @@ unsigned dm_config_maybe_section(const char *str, unsigned len)
return 0;
}
+__attribute__((nonnull(1, 2)))
static struct dm_config_value *_clone_config_value(struct dm_pool *mem,
const struct dm_config_value *v)
{
struct dm_config_value *new_cv;
- if (!v)
- return NULL;
-
if (!(new_cv = _create_value(mem))) {
log_error("Failed to clone config value.");
return NULL;