summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2012-01-20 10:56:30 +0000
committerZdenek Kabelac <zkabelac@redhat.com>2012-01-20 10:56:30 +0000
commit6515946e4d72dd600fea5fba9bbbc8c7a2617047 (patch)
tree2c1e48fff1bc12f809c816099c968f25ebb58936
parentf881095a69283ecf248562b5c97fbc7c1bbda6f9 (diff)
downloadlvm2-6515946e4d72dd600fea5fba9bbbc8c7a2617047.tar.gz
lvm2-6515946e4d72dd600fea5fba9bbbc8c7a2617047.tar.xz
lvm2-6515946e4d72dd600fea5fba9bbbc8c7a2617047.zip
Thin cleanup
Reorder condition so the code is better readable (and shorter).
-rw-r--r--lib/metadata/lv.c18
1 files changed, 8 insertions, 10 deletions
diff --git a/lib/metadata/lv.c b/lib/metadata/lv.c
index 302fd4a1..3fd8a38f 100644
--- a/lib/metadata/lv.c
+++ b/lib/metadata/lv.c
@@ -182,11 +182,10 @@ char *lv_mirror_log_dup(struct dm_pool *mem, const struct logical_volume *lv)
{
struct lv_segment *seg;
- dm_list_iterate_items(seg, &lv->segments) {
- if (!seg_is_mirrored(seg) || !seg->log_lv)
- continue;
- return dm_pool_strdup(mem, seg->log_lv->name);
- }
+ dm_list_iterate_items(seg, &lv->segments)
+ if (seg_is_mirrored(seg) && seg->log_lv)
+ return dm_pool_strdup(mem, seg->log_lv->name);
+
return NULL;
}
@@ -194,11 +193,10 @@ char *lv_pool_lv_dup(struct dm_pool *mem, const struct logical_volume *lv)
{
struct lv_segment *seg;
- dm_list_iterate_items(seg, &lv->segments) {
- if (!seg_is_thin_volume(seg) || !seg->pool_lv)
- continue;
- return dm_pool_strdup(mem, seg->pool_lv->name);
- }
+ dm_list_iterate_items(seg, &lv->segments)
+ if (seg_is_thin_volume(seg) && seg->pool_lv)
+ return dm_pool_strdup(mem, seg->pool_lv->name);
+
return NULL;
}