diff options
| author | Greg Hudson <ghudson@mit.edu> | 2009-01-23 06:51:03 +0000 |
|---|---|---|
| committer | Greg Hudson <ghudson@mit.edu> | 2009-01-23 06:51:03 +0000 |
| commit | 29e98730bfe3b7dfb72bead5577a928157ae5bca (patch) | |
| tree | 615d2872c4a27b774da7016fe541cd85e30d325d /src | |
| parent | eecf7791736228cd0b087b11810bc4ba96d4d022 (diff) | |
| download | krb5-29e98730bfe3b7dfb72bead5577a928157ae5bca.tar.gz krb5-29e98730bfe3b7dfb72bead5577a928157ae5bca.tar.xz krb5-29e98730bfe3b7dfb72bead5577a928157ae5bca.zip | |
Add some output parameter initializations n order to eliminate some
spurious Coverity defects. (Far from a comprehensive pass.)
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21782 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src')
| -rw-r--r-- | src/kdc/network.c | 1 | ||||
| -rw-r--r-- | src/lib/kadm5/srv/svr_iters.c | 3 | ||||
| -rw-r--r-- | src/lib/kdb/kdb5.c | 3 | ||||
| -rw-r--r-- | src/lib/krb5/os/read_msg.c | 5 | ||||
| -rw-r--r-- | src/plugins/preauth/pkinit/pkinit_crypto_openssl.c | 3 |
5 files changed, 13 insertions, 2 deletions
diff --git a/src/kdc/network.c b/src/kdc/network.c index fffaa1e788..4ebaf2b326 100644 --- a/src/kdc/network.c +++ b/src/kdc/network.c @@ -1163,6 +1163,7 @@ make_too_big_error (krb5_data **out) krb5_error_code retval; krb5_data *scratch; + *out = NULL; memset(&errpkt, 0, sizeof(errpkt)); retval = krb5_us_timeofday(kdc_context, &errpkt.stime, &errpkt.susec); diff --git a/src/lib/kadm5/srv/svr_iters.c b/src/lib/kadm5/srv/svr_iters.c index 9774d76ea9..cd3fb41770 100644 --- a/src/lib/kadm5/srv/svr_iters.c +++ b/src/lib/kadm5/srv/svr_iters.c @@ -192,7 +192,8 @@ static kadm5_ret_t kadm5_get_either(int princ, char *regexp; int i, ret; kadm5_server_handle_t handle = server_handle; - + + *princs = NULL; *count = 0; if (exp == NULL) exp = "*"; diff --git a/src/lib/kdb/kdb5.c b/src/lib/kdb/kdb5.c index e76ebe921f..5cc67f9b37 100644 --- a/src/lib/kdb/kdb5.c +++ b/src/lib/kdb/kdb5.c @@ -1861,6 +1861,9 @@ krb5_dbe_lookup_mod_princ_data(context, entry, mod_time, mod_princ) krb5_tl_data tl_data; krb5_error_code code; + *mod_princ = NULL; + *mod_time = 0; + tl_data.tl_data_type = KRB5_TL_MOD_PRINC; if ((code = krb5_dbe_lookup_tl_data(context, entry, &tl_data))) diff --git a/src/lib/krb5/os/read_msg.c b/src/lib/krb5/os/read_msg.c index 77cda8032a..47973bbd8c 100644 --- a/src/lib/krb5/os/read_msg.c +++ b/src/lib/krb5/os/read_msg.c @@ -37,7 +37,10 @@ krb5_read_message(krb5_context context, krb5_pointer fdp, krb5_data *inbuf) int len2, ilen; char *buf = NULL; int fd = *( (int *) fdp); - + + inbuf->data = NULL; + inbuf->length = 0; + if ((len2 = krb5_net_read(context, fd, (char *)&len, 4)) != 4) return((len2 < 0) ? errno : ECONNABORTED); len = ntohl(len); diff --git a/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c b/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c index 15bbbb85c0..c402e2ee10 100644 --- a/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c +++ b/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c @@ -2259,6 +2259,9 @@ server_process_dh(krb5_context context, unsigned char *p = NULL; ASN1_INTEGER *pub_key = NULL; + *dh_pubkey = *server_key = NULL; + *dh_pubkey_len = *server_key_len = 0; + /* get client's received DH parameters that we saved in server_check_dh */ dh = cryptoctx->dh; |