summaryrefslogtreecommitdiffstats
path: root/src/lib/rpc
diff options
context:
space:
mode:
authorBen Kaduk <kaduk@mit.edu>2012-06-27 15:38:47 -0400
committerBen Kaduk <kaduk@mit.edu>2012-07-03 00:43:23 -0400
commitf59478241686d75ece48e8eff6099006cf0bb1b2 (patch)
tree0b9f31ab66c127a9a7f5723524bd94d5a7659613 /src/lib/rpc
parente4a3c43c403a24fcf21a2a67eddf831032ab7ec4 (diff)
downloadkrb5-f59478241686d75ece48e8eff6099006cf0bb1b2.tar.gz
krb5-f59478241686d75ece48e8eff6099006cf0bb1b2.tar.xz
krb5-f59478241686d75ece48e8eff6099006cf0bb1b2.zip
Avoid unsigned/signed comparison in loop condition
The gid_len length is declared as an unsigned int, and loop index 'i' is a signed int. This could manifest as an infinite loop if gid_len is very large. In practice, gid_len should be small, but make 'i' the same type for consistency.
Diffstat (limited to 'src/lib/rpc')
-rw-r--r--src/lib/rpc/svc_auth_unix.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/lib/rpc/svc_auth_unix.c b/src/lib/rpc/svc_auth_unix.c
index 406abf7eb8..a4b87d8ff4 100644
--- a/src/lib/rpc/svc_auth_unix.c
+++ b/src/lib/rpc/svc_auth_unix.c
@@ -66,8 +66,7 @@ gssrpc__svcauth_unix(
char area_machname[MAX_MACHINE_NAME+1];
int area_gids[NGRPS];
} *area;
- u_int auth_len, str_len, gid_len;
- register int i;
+ u_int auth_len, str_len, gid_len, i;
rqst->rq_xprt->xp_auth = &svc_auth_none;