summaryrefslogtreecommitdiffstats
path: root/src/lib/kdb/kdb_default.c
diff options
context:
space:
mode:
authorTom Yu <tlyu@mit.edu>2007-12-14 04:38:42 +0000
committerTom Yu <tlyu@mit.edu>2007-12-14 04:38:42 +0000
commitac438e19b68f18f7f5e485c6cdc215283b99921b (patch)
treee87a5522b5fe6205d305d41b4ae84132dfa23707 /src/lib/kdb/kdb_default.c
parent39a6cc6679e381f890144eac4da2c30bfd8baa2a (diff)
downloadkrb5-ac438e19b68f18f7f5e485c6cdc215283b99921b.tar.gz
krb5-ac438e19b68f18f7f5e485c6cdc215283b99921b.tar.xz
krb5-ac438e19b68f18f7f5e485c6cdc215283b99921b.zip
fix CVE-2007-5972: double fclose() in krb5_def_store_mkey()
ticket: 5857 target_version: 1.6.4 tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20179 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src/lib/kdb/kdb_default.c')
-rw-r--r--src/lib/kdb/kdb_default.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/lib/kdb/kdb_default.c b/src/lib/kdb/kdb_default.c
index 0e5880490e..fd95c83793 100644
--- a/src/lib/kdb/kdb_default.c
+++ b/src/lib/kdb/kdb_default.c
@@ -186,8 +186,7 @@ krb5_def_store_mkey(context, keyfile, mname, key, master_pwd)
kf) != key->length)) {
retval = errno;
(void) fclose(kf);
- }
- if (fclose(kf) == EOF)
+ } else if (fclose(kf) == EOF)
retval = errno;
#if HAVE_UMASK
(void) umask(oumask);