summaryrefslogtreecommitdiffstats
path: root/src/kdc/dispatch.c
diff options
context:
space:
mode:
authorGreg Hudson <ghudson@mit.edu>2010-04-22 03:44:44 +0000
committerGreg Hudson <ghudson@mit.edu>2010-04-22 03:44:44 +0000
commitb2d3007fbb84fa476e3b072c5506cfdf8de0f458 (patch)
tree0e1e8b41f4db616c32ef40507742973bc7a99ad8 /src/kdc/dispatch.c
parent6cc0b1233e8bc9a2027b9ea3b48e52e9aefd208d (diff)
downloadkrb5-b2d3007fbb84fa476e3b072c5506cfdf8de0f458.tar.gz
krb5-b2d3007fbb84fa476e3b072c5506cfdf8de0f458.tar.xz
krb5-b2d3007fbb84fa476e3b072c5506cfdf8de0f458.zip
Eliminate a non-useful NULL check in the KDC's dispatch() function.
If process_as_req or process_tgs_req return successfully, they will always fill in *response. (If they didn't, the subsequence (*response)->length check would crash anyway.) git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23922 dc483132-0cff-0310-8789-dd5450dbe970
Diffstat (limited to 'src/kdc/dispatch.c')
-rw-r--r--src/kdc/dispatch.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/kdc/dispatch.c b/src/kdc/dispatch.c
index 207fa390ad..63ff3b38d8 100644
--- a/src/kdc/dispatch.c
+++ b/src/kdc/dispatch.c
@@ -111,7 +111,7 @@ dispatch(void *cb, struct sockaddr *local_saddr, const krb5_fulladdr *from,
retval = KRB5KRB_AP_ERR_MSG_TYPE;
#ifndef NOCACHE
/* put the response into the lookaside buffer */
- if (!retval && *response != NULL)
+ if (!retval)
kdc_insert_lookaside(pkt, *response);
#endif