Attach format attributes to declarations of various message-formatting

routines under gcc.  In a couple of routines, hard-code the preference
for using the vsnprintf paths instead of list-of-int-arguments hacks
now that we're assuming vsnprintf is available in other places.

Installed headers affected:
  com_err.h (com_err, com_err_va)
  ss.h (ss_error)
  krb5.h (krb5_set_error_message, krb5_vset_error_message)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19653 dc483132-0cff-0310-8789-dd5450dbe970

1 files changed, 7 insertions, 4 deletions

diff --git a/src/appl/telnet/telnetd/utility.c b/src/appl/telnet/telnetd/utility.c
index f4568ec289..a091d08942 100644
--- a/src/appl/telnet/telnetd/utility.c
+++ b/src/appl/telnet/telnetd/utility.c
@@ -393,6 +393,13 @@ netflush()
  */
 static void
 netprintf_ext(int noflush, int seturg, const char *fmt, va_list args)
+#if !defined(__cplusplus) && (__GNUC__ > 2)
+    __attribute__((__format__(__printf__, 3, 0)))
+#endif
+    ;
+
+static void
+netprintf_ext(int noflush, int seturg, const char *fmt, va_list args)
 {
 	size_t remain;
 	size_t maxoutlen;
@@ -412,11 +419,7 @@ netprintf_ext(int noflush, int seturg, const char *fmt, va_list args)
 	if (maxoutlen >= sizeof(buf))
 		return;		/* highly unlikely */
 
-#ifdef HAVE_VSNPRINTF
 	len = vsnprintf(buf, sizeof(buf), fmt, args);
-#else
-	len = vsprintf(buf, fmt, args);	/* XXX need to fix for SunOS? */
-#endif
 
 	/*
 	 * The return value from sprintf()-like functions may be the